Hopiu/RandomWallpaperGnome3
1
0
Fork 0
mirror of https://github.com/Hopiu/RandomWallpaperGnome3.git synced 2026-05-28 00:04:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

first HistoryElement cache implementation

Browse source
This commit is contained in:
Wolfgang Rumpler 2018-07-30 00:29:02 +02:00
parent e95b5ba05e
commit 3852e83943
3 changed files with 47 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
randomwallpaper@iflow.space/elements.js
View file

@ -149,7 +149,12 @@ var HistoryElement = new Lang.Class({
}
}
})
}
},
setIndex: function(index) {
this.prefixLabel.set_text(String(index));
},
});
var CurrentImageElement = new Lang.Class({
@ -289,5 +294,12 @@ var HistorySection = new Lang.Class({
this.actor.add_actor(this.box);
},
/**
* Clears the history section without destroying the child actors.
*/
clearSection: function() {
this.box.remove_all_children();
}
});

42
randomwallpaper@iflow.space/extension.js
View file

@ -77,6 +77,11 @@ var RandomWallpaperEntry = new Lang.Class({
Name: "RandomWallpaperEntry",
logger: null,
/**
* Cache HistoryElements for performance of long histories.
*/
_historySectionCache: {},
_init: function (menuAlignment, nameText) {
this.parent(menuAlignment, nameText);
this.logger = new LoggerModule.Logger('RWG3', 'RandomWallpaperEntry');
@ -184,28 +189,38 @@ var RandomWallpaperEntry = new Lang.Class({
setHistoryList: function () {
this.setCurrentBackgroundElement();
this.historySection.removeAll();
let historyController = wallpaperController.getHistoryController();
let history = historyController.history;
this.historySection.clearSection();
if (history.length <= 1) {
this.clearHistoryList();
return;
}
let existingHistoryElements = [];
for (let i = 1; i < history.length; i++) {
let historyid = history[i].id;
let tmp = new CustomElements.HistoryElement(history[i], i);
let historyID = history[i].id;
let tmp;
tmp.actor.connect('key-focus-in', onEnter);
tmp.actor.connect('key-focus-out', onLeave);
tmp.actor.connect('enter-event', onEnter);
if (!(historyID in this._historySectionCache)) {
tmp = new CustomElements.HistoryElement(history[i], i);
tmp.connect('activate', onSelect);
tmp.actor.connect('key-focus-in', onEnter);
tmp.actor.connect('key-focus-out', onLeave);
tmp.actor.connect('enter-event', onEnter);
this.historySection.addMenuItem(tmp);
tmp.connect('activate', onSelect);
this._historySectionCache[historyID] = tmp;
} else {
tmp = this._historySectionCache[historyID];
tmp.setIndex(i);
}
existingHistoryElements.push(historyID)
this.historySection.addMenuItem(tmp, i-1);
}
this._cleanupHistoryCache(existingHistoryElements);
function onLeave(actor) {
wallpaperController.resetWallpaper();
@ -221,7 +236,16 @@ var RandomWallpaperEntry = new Lang.Class({
},
_cleanupHistoryCache: function(existingIDs) {
let destroyIDs = Object.keys(this._historySectionCache).filter((i) => existingIDs.indexOf(i) === -1);
destroyIDs.map(id => {
delete this._historySectionCache[id];
});
},
clearHistoryList: function () {
this._cleanupHistoryCache([]);
this.historySection.removeAll();
let empty = new PopupMenu.PopupMenuItem('No recent wallpaper ...', {

1
randomwallpaper@iflow.space/prefs.js
View file

@ -249,6 +249,7 @@ var RandomWallpaperSettings = new Lang.Class({
let text = newWallpaperButton.get_label();
newWallpaperButton.set_label("Loading ...");
this._wallpaperController.update();
this._wallpaperController.fetchNewWallpaper(()=>{
this._wallpaperController.update();
newWallpaperButton.set_label(text);