Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-04-20 14:50:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(input): bind inputs to the 'input' event

Browse source 
The input event is fired on all non-ie browsers whenever the contents of an input
field changes. This means that we now support cut&paste via mouse which
was previously unsupported.

IE8 and older don't support this events and IE9 has a problematic
support for it, so we can't rely solely on this event and drop keydown
and change events.
This commit is contained in:
bartes 2011-11-18 20:10:04 +01:00 committed by Igor Minar
parent c28662d28d
commit 0c534644bc
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/widget/input.js
View file

@ -817,7 +817,7 @@ angularWidget('input', function(inputElement){
inputElement.val(widget.$viewValue || ''); inputElement.val(widget.$viewValue || '');
}; };
inputElement.bind('keydown change', function(event){ inputElement.bind('keydown change input', function(event) {
var key = event.keyCode; var key = event.keyCode;
if (/*command*/ key != 91 && if (/*command*/ key != 91 &&
/*modifiers*/ !(15 < key && key < 19) && /*modifiers*/ !(15 < key && key < 19) &&

9
test/widget/inputSpec.js
View file

@ -112,7 +112,7 @@ describe('widget: input', function() {
describe("input", function() { describe("input", function() {
describe("text", function() { describe("text", function() {
it('should input-text auto init and handle keydown/change events', function() { it('should input-text auto init and listen on keydown/change/input events', function() {
compile('<input type="text" ng:model="name"/>'); compile('<input type="text" ng:model="name"/>');
scope.name = 'Adam'; scope.name = 'Adam';
@ -130,6 +130,13 @@ describe('widget: input', function() {
browserTrigger(element, 'change'); browserTrigger(element, 'change');
defer.flush(); defer.flush();
expect(scope.name).toEqual('Kai'); expect(scope.name).toEqual('Kai');
if (!(msie<=8)) {
element.val('Lunar');
browserTrigger(element, 'input');
defer.flush();
expect(scope.name).toEqual('Lunar');
}
}); });