Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-03-17 07:40:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix:jqLite: Normalize non-existing attributes to undefined as jQuery

Browse source 
jqLite was returning null, but jQuery returns undefined
This commit is contained in:
Vojta Jina 2011-07-08 12:18:26 +02:00 committed by Igor Minar
parent 9ee9ca13da
commit 10da625ed9
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/jqLite.js
View file

@ -266,7 +266,9 @@ forEach({
} else if (element.getAttribute) {
// the extra argument "2" is to get the right thing for a.href in IE, see jQuery code
// some elements (e.g. Document) don't have get attribute, so return undefined
return element.getAttribute(name, 2);
var ret = element.getAttribute(name, 2);
// normalize non-existing attributes to undefined (as jQuery)
return ret === null ? undefined : ret;
}
},

4
test/jqLiteSpec.js
View file

@ -162,6 +162,10 @@ describe('jqLite', function(){
expect(select.attr('multiple')).toEqual(true);
});
it('should return undefined for non-existing attributes', function() {
var elm = jqLite('<div class="any">a</div>');
expect(elm.attr('non-existing')).toBeUndefined();
});
});