Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-03-16 23:30:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix($resource): prevent URL template from collapsing into an empty string

Browse source 
if url template would result in an empty string, we should make a request
to '/' instead.

Closes #5455
Closes #5493
This commit is contained in:
Gias Kay Lee 2013-12-20 23:15:46 +08:00 committed by Igor Minar
parent 01c5be4681
commit 131e4014b8
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ngResource/resource.js
View file

@ -401,7 +401,7 @@ angular.module('ngResource', ['ng']).
});
// strip trailing slashes and set the url
url = url.replace(/\/+$/, '');
url = url.replace(/\/+$/, '') || '/';
// then replace collapse `/.` if found in the last URL path segment before the query
// E.g. `http://url.com/id./format?q=x` becomes `http://url.com/id.format?q=x`
url = url.replace(/\/\.(?=\w+($|\?))/, '.');

7
test/ngResource/resourceSpec.js
View file

@ -150,6 +150,13 @@ describe("resource", function() {
R.get({a:6, b:7, c:8});
});
it('should not collapsed the url into an empty string', function() {
var R = $resource('/:foo/:bar/');
$httpBackend.when('GET', '/').respond('{}');
R.get({});
});
it('should support escaping colons in url template', function() {
var R = $resource('http://localhost\\:8080/Path/:a/\\:stillPath/:b');