fix all closure compilation warnings due to invalid function types

This commit is contained in:
Igor Minar 2010-11-18 17:03:43 -08:00
parent 7ee102eecf
commit 1719b0aca5
3 changed files with 16 additions and 16 deletions

View file

@ -83,7 +83,7 @@ function Browser(location, document, head, XHR, $log) {
* @name angular.service.$browser#notifyWhenNoOutstandingRequests * @name angular.service.$browser#notifyWhenNoOutstandingRequests
* @methodOf angular.service.$browser * @methodOf angular.service.$browser
* *
* @param {function} callback Function that will be called when no outstanding request * @param {function()} callback Function that will be called when no outstanding request
*/ */
self.notifyWhenNoOutstandingRequests = function(callback) { self.notifyWhenNoOutstandingRequests = function(callback) {
if (outstandingRequestCount === 0) { if (outstandingRequestCount === 0) {
@ -114,12 +114,12 @@ function Browser(location, document, head, XHR, $log) {
* @name angular.service.$browser#addPollFn * @name angular.service.$browser#addPollFn
* @methodOf angular.service.$browser * @methodOf angular.service.$browser
* *
* @param {function} fn Poll function to add * @param {function()} fn Poll function to add
* *
* @description * @description
* Adds a function to the list of functions that poller periodically executes * Adds a function to the list of functions that poller periodically executes
* *
* @returns {function} the added function * @returns {function()} the added function
*/ */
self.addPollFn = function(fn) { self.addPollFn = function(fn) {
pollFns.push(fn); pollFns.push(fn);
@ -133,7 +133,7 @@ function Browser(location, document, head, XHR, $log) {
* @methodOf angular.service.$browser * @methodOf angular.service.$browser
* *
* @param {number} interval How often should browser call poll functions (ms) * @param {number} interval How often should browser call poll functions (ms)
* @param {function} setTimeout Reference to a real or fake `setTimeout` function. * @param {function()} setTimeout Reference to a real or fake `setTimeout` function.
* *
* @description * @description
* Configures the poller to run in the specified intervals, using the specified * Configures the poller to run in the specified intervals, using the specified

View file

@ -258,7 +258,7 @@ function createScope(parent, providers, instanceCache) {
expect(fn()).toEqual(scope); expect(fn()).toEqual(scope);
</pre> </pre>
* *
* @param {function} fn Function to be bound. * @param {function()} fn Function to be bound.
*/ */
$bind: bind(instance, bind, instance), $bind: bind(instance, bind, instance),
$get: bind(instance, getter, instance), $get: bind(instance, getter, instance),
@ -292,7 +292,7 @@ function createScope(parent, providers, instanceCache) {
expect(scope.sum).toEqual(3); expect(scope.sum).toEqual(3);
</pre> </pre>
* *
* @param {(string|function)=} exp An angular expression to be compiled to a function or a js * @param {(string|function())=} exp An angular expression to be compiled to a function or a js
* function. * function.
* *
* @returns {*} The result of calling compiled `exp` with `this` set to the current scope. * @returns {*} The result of calling compiled `exp` with `this` set to the current scope.
@ -356,8 +356,8 @@ function createScope(parent, providers, instanceCache) {
expect(body.hasClass('ng-exception')).toEqual(true); expect(body.hasClass('ng-exception')).toEqual(true);
</pre> </pre>
* *
* @param {string|function} expression Angular expression to evaluate. * @param {string|function()} expression Angular expression to evaluate.
* @param {function|DOMElement} exceptionHandler Function to be called or DOMElement to be * @param {function()|DOMElement} exceptionHandler Function to be called or DOMElement to be
* decorated. * decorated.
* @returns {*} The result of `expression` evaluation. * @returns {*} The result of `expression` evaluation.
*/ */
@ -411,12 +411,12 @@ function createScope(parent, providers, instanceCache) {
expect(scope.counter).toEqual(2); expect(scope.counter).toEqual(2);
</pre> </pre>
* *
* @param {function|string} watchExp Expression that should be evaluated and checked for change * @param {function()|string} watchExp Expression that should be evaluated and checked for
* during each eval cycle. Can be an angular string expression or a function. * change during each eval cycle. Can be an angular string expression or a function.
* @param {function|string} listener Function (or angular string expression) that gets called * @param {function()|string} listener Function (or angular string expression) that gets called
* every time the value of the `watchExp` changes. The function will be called with two * every time the value of the `watchExp` changes. The function will be called with two
* parameters, `newValue` and `oldValue`. * parameters, `newValue` and `oldValue`.
* @param {(function|DOMElement)=} [exceptionHanlder=angular.service.$exceptionHandler] Handler * @param {(function()|DOMElement)=} [exceptionHanlder=angular.service.$exceptionHandler] Handler
* that gets called when `watchExp` or `listener` throws an exception. If a DOMElement is * that gets called when `watchExp` or `listener` throws an exception. If a DOMElement is
* specified as handler, the element gets decorated by angular with the information about the * specified as handler, the element gets decorated by angular with the information about the
* exception. * exception.
@ -465,8 +465,8 @@ function createScope(parent, providers, instanceCache) {
</pre> </pre>
* *
* @param {number} [priority=0] Execution priority. Lower priority numbers get executed first. * @param {number} [priority=0] Execution priority. Lower priority numbers get executed first.
* @param {string|function} expr Angular expression or function to be executed. * @param {string|function()} expr Angular expression or function to be executed.
* @param {(function|DOMElement)=} [exceptionHandler=angular.service.$exceptionHandler] Handler * @param {(function()|DOMElement)=} [exceptionHandler=angular.service.$exceptionHandler] Handler
* function to call or DOM element to decorate when an exception occurs. * function to call or DOM element to decorate when an exception occurs.
* *
*/ */
@ -566,7 +566,7 @@ function createScope(parent, providers, instanceCache) {
* - is a child of the current scope * - is a child of the current scope
* - will {@link angular.scope.$become $become} of type specified via `constructor` * - will {@link angular.scope.$become $become} of type specified via `constructor`
* *
* @param {function} constructor Constructor function of the type the new scope should assume. * @param {function()} constructor Constructor function of the type the new scope should assume.
* @returns {Object} The newly created child scope. * @returns {Object} The newly created child scope.
* *
*/ */

View file

@ -624,7 +624,7 @@ angularServiceInject('$route', function(location) {
* @name angular.service.$route#onChange * @name angular.service.$route#onChange
* @methodOf angular.service.$route * @methodOf angular.service.$route
* *
* @param {function} fn Function that will be called on route change * @param {function()} fn Function that will be called on route change
* *
* @description * @description
* Register a handler function that will be called when route changes * Register a handler function that will be called when route changes