Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-05-12 00:43:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore(validate-commit-msg.js): increase the max line limit for commit messages from 70 to 100

Browse source
This commit is contained in:
Igor Minar 2013-10-24 14:55:17 -07:00
parent 82dec9b81e
commit 1ae34aac81
3 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
changelog.js
View file

@ -16,7 +16,6 @@ var LINK_ISSUE = '[#%s](https://github.com/angular/angular.js/issues/%s)';
var LINK_COMMIT = '[%s](https://github.com/angular/angular.js/commit/%s)'; var LINK_COMMIT = '[%s](https://github.com/angular/angular.js/commit/%s)';
var EMPTY_COMPONENT = '$$'; var EMPTY_COMPONENT = '$$';
var MAX_SUBJECT_LENGTH = 80;
var warn = function() { var warn = function() {
@ -54,11 +53,6 @@ var parseRawCommit = function(raw) {
return null; return null;
} }
if (match[3].length > MAX_SUBJECT_LENGTH) {
warn('Too long subject: %s %s', msg.hash, msg.subject);
match[3] = match[3].substr(0, MAX_SUBJECT_LENGTH);
}
msg.type = match[1]; msg.type = match[1];
msg.component = match[2]; msg.component = match[2];
msg.subject = match[3]; msg.subject = match[3];

2
validate-commit-msg.js
View file

@ -12,7 +12,7 @@ var fs = require('fs');
var util = require('util'); var util = require('util');
var MAX_LENGTH = 70; var MAX_LENGTH = 100;
var PATTERN = /^(?:fixup!\s*)?(\w*)(\(([\w\$\.\-\*/]*)\))?\: (.*)$/; var PATTERN = /^(?:fixup!\s*)?(\w*)(\(([\w\$\.\-\*/]*)\))?\: (.*)$/;
var IGNORED = /^WIP\:/; var IGNORED = /^WIP\:/;
var TYPES = { var TYPES = {

7
validate-commit-msg.spec.js
View file

@ -38,12 +38,11 @@ describe('validate-commit-msg.js', function() {
}); });
it('should validate 70 characters length', function() { it('should validate 100 characters length', function() {
var msg = 'fix($compile): something super mega extra giga tera long, maybe even longer... ' + var msg = "fix($compile): something super mega extra giga tera long, maybe even longer and longer and longer... ";
'way over 80 characters';
expect(m.validateMessage(msg)).toBe(INVALID); expect(m.validateMessage(msg)).toBe(INVALID);
expect(errors).toEqual(['INVALID COMMIT MSG: is longer than 70 characters !']); expect(errors).toEqual(['INVALID COMMIT MSG: is longer than 100 characters !']);
}); });