Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-03-17 07:40:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(ngRepeat): correctly iterate over array-like objects

Browse source 
Check if the object is array-like to iterate over it like it's done with arrays.

Closes #2546
This commit is contained in:
Gonzalo Ruiz de Villa 2013-05-01 01:19:44 +02:00 committed by Pete Bacon Darwin
parent 6452707d40
commit 1d8e11ddfb
2 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ng/directive/ngRepeat.js
View file

@ -212,7 +212,7 @@ var ngRepeatDirective = ['$parse', '$animator', function($parse, $animator) {
nextBlockOrder = [];
if (isArray(collection)) {
if (isArrayLike(collection)) {
collectionKeys = collection;
} else {
// if object, extract keys, sort them and use to determine order of iteration over obj props

20
test/ng/directive/ngRepeatSpec.js
View file

@ -55,6 +55,26 @@ describe('ngRepeat', function() {
});
it('should iterate over an array-like object', function() {
element = $compile(
'<ul>' +
'<li ng-repeat="item in items">{{item.name}};</li>' +
'</ul>')(scope);
document.body.innerHTML = "<p>" +
"<a name='x'>a</a>" +
"<a name='y'>b</a>" +
"<a name='x'>c</a>" +
"</p>";
var htmlCollection = document.getElementsByTagName('a')
scope.items = htmlCollection;
scope.$digest();
expect(element.find('li').length).toEqual(3);
expect(element.text()).toEqual('x;y;x;');
});
it('should iterate over on object/map', function() {
element = $compile(
'<ul>' +