mirror of
https://github.com/Hopiu/angular.js.git
synced 2026-03-18 07:50:22 +00:00
test(form): fix broken preventDefault test
the original test relied on incorrect assumptions about how jasmine async tests work (when setTimeout is triggered) and how browser reloads a page (the sequence of events) and thus the test passes even when the default is not prevented. this change fixes the test by registering an extra submit event handler that checks if the default was prevented. if the default was not prevented, the test will fail and the page will be reloaded causing the test runner to panic.
This commit is contained in:
parent
6b75475ce3
commit
263f47819f
1 changed files with 14 additions and 6 deletions
|
|
@ -128,17 +128,25 @@ describe('form', function() {
|
|||
describe('preventing default submission', function() {
|
||||
|
||||
it('should prevent form submission', function() {
|
||||
var startingUrl = '' + window.location;
|
||||
doc = jqLite('<form name="myForm"><input type="submit" value="submit" />');
|
||||
var nextTurn = false,
|
||||
reloadPrevented;
|
||||
|
||||
doc = jqLite('<form><input type="submit" value="submit" ></form>');
|
||||
$compile(doc)(scope);
|
||||
|
||||
doc.bind('submit', function(e) {
|
||||
reloadPrevented = e.defaultPrevented;
|
||||
});
|
||||
|
||||
browserTrigger(doc.find('input'));
|
||||
waitsFor(
|
||||
function() { return true; },
|
||||
'let browser breath, so that the form submission can manifest itself', 10);
|
||||
|
||||
// let the browser process all events (and potentially reload the page)
|
||||
setTimeout(function() { nextTurn = true;});
|
||||
|
||||
waitsFor(function() { return nextTurn; });
|
||||
|
||||
runs(function() {
|
||||
expect('' + window.location).toEqual(startingUrl);
|
||||
expect(reloadPrevented).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue