Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-05-28 15:28:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

docs($interval): remind the developer to destroy their intervals

Browse source 
It is essential that users of `$interval` destroy the interval when they are finished.
Otherwise you can get memory leaks.
Often `$intervals` are used in directives or controllers and developers don't think
about what happens when the component is destroyed.
If a directive/controller scope is destroyed, then the $interval should be destroyed as well.
This could cause some issues with developers who assume that the interval will be cleared
for them when the scope is destroyed.

Closes #5377

I believe that the library could/should handle this as well, but thats another issue.
This commit is contained in:
Josh Kurz 2013-12-12 01:39:40 -05:00 committed by Pete Bacon Darwin
parent 9865a7c0ad
commit 277a5ea05d
1 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/ng/interval.js
View file

@ -24,6 +24,14 @@ function $IntervalProvider() {
* In tests you can use {@link ngMock.$interval#methods_flush `$interval.flush(millis)`} to * In tests you can use {@link ngMock.$interval#methods_flush `$interval.flush(millis)`} to
* move forward by `millis` milliseconds and trigger any functions scheduled to run in that * move forward by `millis` milliseconds and trigger any functions scheduled to run in that
* time. * time.
*
* <div class="alert alert-warning">
* **Note**: Intervals created by this service must be explicitly destroyed when you are finished
* with them. In particular they are not automatically destroyed when a controller's scope or a
* directive's element are destroyed.
* You should take this into consideration and make sure to always cancel the interval at the
* appropriate moment. See the example below for more details on how and when to do this.
* </div>
* *
* @param {function()} fn A function that should be called repeatedly. * @param {function()} fn A function that should be called repeatedly.
* @param {number} delay Number of milliseconds between each function call. * @param {number} delay Number of milliseconds between each function call.
@ -52,20 +60,27 @@ function $IntervalProvider() {
$scope.blood_1 = $scope.blood_1 - 3; $scope.blood_1 = $scope.blood_1 - 3;
$scope.blood_2 = $scope.blood_2 - 4; $scope.blood_2 = $scope.blood_2 - 4;
} else { } else {
$interval.cancel(stop); $scope.stopFight();
} }
}, 100); }, 100);
}; };
$scope.stopFight = function() { $scope.stopFight = function() {
$interval.cancel(stop); if (angular.isDefined(stop)) {
stop = undefined; $interval.cancel(stop);
stop = undefined;
}
}; };
$scope.resetFight = function() { $scope.resetFight = function() {
$scope.blood_1 = 100; $scope.blood_1 = 100;
$scope.blood_2 = 120; $scope.blood_2 = 120;
} }
$scope.$on('$destroy', function() {
// Make sure that the interval is destroyed too
$scope.stopFight();
});
} }
angular.module('time', []) angular.module('time', [])