Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-05-24 13:53:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix($compile): safely create transclude comment nodes

Browse source 
Closes #1740
This commit is contained in:
Igor Minar 2013-01-09 22:07:33 -08:00
parent 98489a1d0c
commit 2ba458387d
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ng/compile.js
View file

@ -575,7 +575,7 @@ function $CompileProvider($provide) {
if (directiveValue == 'element') { if (directiveValue == 'element') {
$template = jqLite(compileNode); $template = jqLite(compileNode);
$compileNode = templateAttrs.$$element = $compileNode = templateAttrs.$$element =
jqLite('<!-- ' + directiveName + ': ' + templateAttrs[directiveName] + ' -->'); jqLite(document.createComment(' ' + directiveName + ': ' + templateAttrs[directiveName] + ' '));
compileNode = $compileNode[0]; compileNode = $compileNode[0];
replaceWith($rootElement, jqLite($template[0]), compileNode); replaceWith($rootElement, jqLite($template[0]), compileNode);
childTranscludeFn = compile($template, transcludeFn, terminalPriority); childTranscludeFn = compile($template, transcludeFn, terminalPriority);

10
test/ng/compileSpec.js
View file

@ -2222,5 +2222,15 @@ describe('$compile', function() {
expect(nodeName_(comment)).toBe('#comment'); expect(nodeName_(comment)).toBe('#comment');
}); });
}); });
it('should safely create transclude comment node and not break with "-->"',
inject(function($rootScope) {
// see: https://github.com/angular/angular.js/issues/1740
element = $compile('<ul><li ng-repeat="item in [\'-->\', \'x\']">{{item}}|</li></ul>')($rootScope);
$rootScope.$digest();
expect(element.text()).toBe('-->|x|');
}));
}); });
}); });