Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-05-09 15:24:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(isElement): return boolean value rather than truthy value.

Browse source 
angular.isElement currently returns a truthy object/function, or false. This
patch aims to correct this behaviour by casting the result of the isElement
expression to a boolean value via double-negation.

Closes #4519
Closes #4534
This commit is contained in:
Caitlin Potter 2013-10-19 15:41:06 -04:00 committed by Igor Minar
parent 785a5fd7c1
commit 2dbb6f9a54
2 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/Angular.js
View file

@ -565,9 +565,9 @@ var trim = (function() {
* @returns {boolean} True if `value` is a DOM element (or wrapped jQuery element). * @returns {boolean} True if `value` is a DOM element (or wrapped jQuery element).
*/ */
function isElement(node) { function isElement(node) {
return node && return !!(node &&
(node.nodeName // we are a direct element (node.nodeName // we are a direct element
|| (node.on && node.find)); // we have an on and find method part of jQuery API || (node.on && node.find))); // we have an on and find method part of jQuery API
} }
/** /**

13
test/AngularSpec.js
View file

@ -1079,4 +1079,17 @@ describe('angular', function() {
} }
}); });
describe('isElement', function() {
it('should return a boolean value', inject(function($compile, $document, $rootScope) {
var element = $compile('<p>Hello, world!</p>')($rootScope),
body = $document.find('body')[0],
expected = [false, false, false, false, false, false, false, true, true],
tests = [null, undefined, "string", 1001, {}, 0, false, body, element];
angular.forEach(tests, function(value, idx) {
var result = angular.isElement(value);
expect(typeof result).toEqual('boolean');
expect(result).toEqual(expected[idx]);
});
}));
});
}); });