Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-03-22 01:10:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(*): don't use instanceof to detect arrays

Browse source 
this breaks when multiple javascript contexts are involved - like in node-webkit

see original PR: #1966

Closes #1966
This commit is contained in:
Igor Minar 2013-02-14 16:37:00 -08:00
parent 37bdcc984a
commit 3c2aee01b0
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ng/filter/filter.js
View file

@ -106,7 +106,7 @@
*/
function filterFilter() {
return function(array, expression, comperator) {
if (!(array instanceof Array)) return array;
if (!isArray(array)) return array;
var predicates = [];
predicates.check = function(value) {
for (var j = 0; j < predicates.length; j++) {

2
src/ng/filter/orderBy.js
View file

@ -89,7 +89,7 @@
orderByFilter.$inject = ['$parse'];
function orderByFilter($parse){
return function(array, sortPredicate, reverseOrder) {
if (!(array instanceof Array)) return array;
if (!isArray(array)) return array;
if (!sortPredicate) return array;
sortPredicate = isArray(sortPredicate) ? sortPredicate: [sortPredicate];
sortPredicate = map(sortPredicate, function(predicate){