Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-03-17 07:40:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(ngPluralize): handle the empty string as a valid override

Browse source 
Fix the check for overrides so it is able to handle the empty string

Closes #2575
This commit is contained in:
Lucas Galfasó 2013-05-07 09:14:57 -03:00 committed by Pete Bacon Darwin
parent 661390aef3
commit 42ce8f7f55
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ng/directive/ngPluralize.js
View file

@ -194,7 +194,7 @@ var ngPluralizeDirective = ['$locale', '$interpolate', function($locale, $interp
if (!isNaN(value)) {
//if explicit number rule such as 1, 2, 3... is defined, just use it. Otherwise,
//check it against pluralization rules in $locale service
if (!whens[value]) value = $locale.pluralCat(value - offset);
if (!(value in whens)) value = $locale.pluralCat(value - offset);
return whensExpFns[value](scope, element, true);
} else {
return '';

15
test/ng/directive/ngPluralizeSpec.js
View file

@ -99,6 +99,21 @@ describe('ngPluralize', function() {
});
describe('edge cases', function() {
it('should be able to handle empty strings as possible values', inject(function($rootScope, $compile) {
element = $compile(
'<ng:pluralize count="email"' +
"when=\"{'0': ''," +
"'one': 'Some text'," +
"'other': 'Some text'}\">" +
'</ng:pluralize>')($rootScope);
$rootScope.email = '0';
$rootScope.$digest();
expect(element.text()).toBe('');
}));
});
describe('deal with pluralized strings with offset', function() {
it('should show single/plural strings with offset', inject(function($rootScope, $compile) {
element = $compile(