Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-05-09 15:24:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(markup): Make special attrs such as ng:href work even without binding

Browse source 
- special attrs such as ng:href, ng:check did not work as intended when
their values do not contain bindings. And this commit is to fix that

Closes #534
This commit is contained in:
Di Peng 2011-08-25 16:31:00 -07:00
parent 452607fc64
commit 5927b23ef3
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/markups.js
View file

@ -418,7 +418,7 @@ angularAttrMarkup('{{}}', function(value, name, element){
value = decodeURI(value); value = decodeURI(value);
var bindings = parseBindings(value), var bindings = parseBindings(value),
bindAttr; bindAttr;
if (hasBindings(bindings)) { if (hasBindings(bindings) || SPECIAL_ATTRS[name]) {
element.removeAttr(name); element.removeAttr(name);
bindAttr = fromJson(element.attr(NG_BIND_ATTR) || "{}"); bindAttr = fromJson(element.attr(NG_BIND_ATTR) || "{}");
bindAttr[SPECIAL_ATTRS[name] || name] = value; bindAttr[SPECIAL_ATTRS[name] || name] = value;

8
test/markupSpec.js
View file

@ -154,6 +154,14 @@ describe("markups", function(){
expect(sortedHtml(element)).toEqual('<a ng:bind-attr="{"href":"{{url}}","rel":"{{rel}}"}"></a>'); expect(sortedHtml(element)).toEqual('<a ng:bind-attr="{"href":"{{url}}","rel":"{{rel}}"}"></a>');
}); });
it('should bind Text with no Bindings', function() {
forEach('src,href,checked,disabled,multiple,readonly,selected'.split(','), function(name) {
compile('<div ng:' + name +'="some"></div>');
expect(sortedHtml(element)).toEqual('<div ng:bind-attr="{"' + name +'":"some"}"></div>');
dealoc(element);
});
})
it('should Parse Text With No Bindings', function(){ it('should Parse Text With No Bindings', function(){
var parts = parseBindings("a"); var parts = parseBindings("a");
assertEquals(parts.length, 1); assertEquals(parts.length, 1);