Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-03-16 23:30:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix($browser/$location): single quote in url causes infinite digest in FF

Browse source 
The real issue is in FF, see https://bugzilla.mozilla.org/show_bug.cgi?id=407172.

FF overly encodes stuff which breaks our expectations and then we fail .url() != currentUrl.absUrl()
comparison unexpectidly, which leads to infinite digest.

The workaround is to correct for this inconsistency in $browser and decode any single quotes in urls.

Closes #920
This commit is contained in:
Igor Minar 2012-05-13 21:53:19 -07:00
parent 4e65635f85
commit 679cb8a74a
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/ng/browser.js
View file

@ -165,7 +165,8 @@ function Browser(window, document, $log, $sniffer) {
return self;
// getter
} else {
return location.href;
// the replacement is a workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=407172
return location.href.replace(/%27/g,"'");
}
};

6
test/ng/browserSpecs.js
View file

@ -462,6 +462,12 @@ describe('browser', function() {
it('should return $browser to allow chaining', function() {
expect(browser.url('http://any.com')).toBe(browser);
});
it('should decode single quotes to work around FF bug 407273', function() {
fakeWindow.location.href = "http://ff-bug/?single%27quote";
expect(browser.url()).toBe("http://ff-bug/?single'quote");
});
});
describe('urlChange', function() {