Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-03-17 07:40:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

revert: fix($sce): allow IE7 standards mode to pass non-quirks mode test

Browse source 
This reverts commit 637c9b1611.
(ref #3633 and #3646)

The minimum bar for $sce is IE8 in standards mode.  IE7 standards mode
is not supported.  If you must support IE7, you should disable $sce
completely.

  angular.module('ie7support', []).config(function($sceProvider) {
    // Completely disable SCE to support IE7.
    $sceProvider.enabled(false);
  });
This commit is contained in:
Chirayu Krishnappa 2013-08-22 16:31:40 -07:00
parent a671b0423c
commit 699f86c535
2 changed files with 2 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ng/sce.js
View file

@ -620,7 +620,7 @@ function $SceProvider() {
// the "expression(javascript expression)" syntax which is insecure.
if (enabled && msie) {
var documentMode = $document[0].documentMode;
if (documentMode !== undefined && documentMode < 7) {
if (documentMode !== undefined && documentMode < 8) {
throw $sceMinErr('iequirks',
'Strict Contextual Escaping does not support Internet Explorer version < 9 in quirks ' +
'mode. You can fix this by adding the text <!doctype html> to the top of your HTML ' +

10
test/ng/sceSpecs.js
View file

@ -58,11 +58,7 @@ describe('SCE', function() {
}
it('should throw an exception when sce is enabled in quirks mode', function() {
runTest(true, 5, true);
});
it('should NOT throw an exception when sce is enabled and in IE7 standards mode', function() {
runTest(true, 7, false);
runTest(true, 7, true);
});
it('should NOT throw an exception when sce is enabled and in standards mode', function() {
@ -74,10 +70,6 @@ describe('SCE', function() {
});
it('should NOT throw an exception when sce is disabled even when in quirks mode', function() {
runTest(false, 5, false);
});
it('should NOT throw an exception when sce is disabled and in IE7 standards mode', function() {
runTest(false, 7, false);
});