Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-05-21 04:41:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

test($sce): ie8 fix for entire file

Browse source 
Ref: https://github.com/angular/angular.js/pull/4221#/issuecomment-25515813

Closes #4221
This commit is contained in:
Chirayu Krishnappa 2013-10-02 11:10:04 -07:00
parent 10cc1a42c9
commit 78a5889bc6
1 changed files with 14 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
test/ng/sceSpecs.js
View file

@ -2,6 +2,12 @@
describe('SCE', function() { describe('SCE', function() {
// Work around an IE8 bug. Though window.inject === angular.mock.inject, if it's invoked the
// window scope, IE8 loses the exception object that bubbles up and replaces it with a TypeError.
// By using a local alias, it gets invoked on the global scope instead of window.
// Ref: https://github.com/angular/angular.js/pull/4221#/issuecomment-25515813
var inject = angular.mock.inject;
describe('when disabled', function() { describe('when disabled', function() {
beforeEach(function() { beforeEach(function() {
module(function($sceProvider) { module(function($sceProvider) {
@ -262,9 +268,7 @@ describe('SCE', function() {
$sceDelegateProvider.resourceUrlBlacklist(cfg.blackList); $sceDelegateProvider.resourceUrlBlacklist(cfg.blackList);
} }
}); });
// This needs to be angular.mock.inject even though it's === window.inject. inject(testFn);
// Ref: https://github.com/angular/angular.js/pull/4221#/issuecomment-25515813
angular.mock.inject(testFn);
} }
} }
@ -399,20 +403,13 @@ describe('SCE', function() {
expect($sce.getTrustedResourceUrl('http://example.com/foo:1/2.3?4&5-6')).toEqual('http://example.com/foo:1/2.3?4&5-6'); expect($sce.getTrustedResourceUrl('http://example.com/foo:1/2.3?4&5-6')).toEqual('http://example.com/foo:1/2.3?4&5-6');
})); }));
// TODO(chirayu): This throws a very helpful TypeError exception - "Object doesn't support it('should not accept *** in the string', function() {
// this property or method". Tracing using the debugger on IE8 developer tools shows me one expect(function() {
// catch(e) block where the exception is correct, but jumping up to the parent catch block has runTest({whiteList: ['http://***']}, null)();
// the TypeError exception. I've been unable to repro this outside this snippet or figure out }).toThrowMinErr('$injector', 'modulerr', new RegExp(
// why this is happening. Until then, this test doesn't run on IE8. /Failed to instantiate module function ?\(\$sceDelegateProvider\) due to:\n/.source +
if (!msie || msie > 8) { /[^[]*\[\$sce:iwcard\] Illegal sequence \*\*\* in string matcher\. String: http:\/\/\*\*\*/.source));
it('should not accept *** in the string', function() { });
expect(function() {
runTest({whiteList: ['http://***']}, null)();
}).toThrowMinErr('$injector', 'modulerr', new RegExp(
/Failed to instantiate module function ?\(\$sceDelegateProvider\) due to:\n/.source +
/[^[]*\[\$sce:iwcard\] Illegal sequence \*\*\* in string matcher\. String: http:\/\/\*\*\*/.source));
});
}
}); });
describe('"self" matcher', function() { describe('"self" matcher', function() {