fix($sniffer): report history false on Android < 4

Android has history.pushState, but it does not update the location correctly:
http://code.google.com/p/android/issues/detail?id=17471

Closes #904
This commit is contained in:
Vojta Jina 2012-05-14 14:14:52 -07:00
parent c1533ef576
commit 7b739c9702
4 changed files with 11 additions and 4 deletions

View file

@ -14,10 +14,15 @@
*/
function $SnifferProvider() {
this.$get = ['$window', function($window) {
var eventSupport = {};
var eventSupport = {},
android = int((/android (\d+)/.exec(lowercase($window.navigator.userAgent)) || [])[1]);
return {
history: !!($window.history && $window.history.pushState),
// Android has history.pushState, but it does not update location correctly
// so let's not use the history API at all.
// http://code.google.com/p/android/issues/detail?id=17471
// https://github.com/angular/angular.js/issues/904
history: !!($window.history && $window.history.pushState && !(android < 4)),
hashchange: 'onhashchange' in $window &&
// IE8 compatible mode lies
(!$window.document.documentMode || $window.document.documentMode > 7),

View file

@ -51,7 +51,8 @@ describe('$anchorScroll', function() {
elmSpy = {};
$provide.value('$window', {
scrollTo: jasmine.createSpy('$window.scrollTo'),
document: document
document: document,
navigator: {}
});
}));

View file

@ -6,7 +6,7 @@ describe('$log', function() {
beforeEach(module(function($provide){
$window = {};
$window = {navigator: {}};
logger = '';
log = function() { logger+= 'log;'; };
warn = function() { logger+= 'warn;'; };

View file

@ -3,6 +3,7 @@
describe('$sniffer', function() {
function sniffer($window) {
$window.navigator = {};
return new $SnifferProvider().$get[1]($window);
}