Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-03-26 03:00:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix($$urlUtils): remove dependency on $window

Browse source 
$window may be mocked out in tests causing those tests to fail.  So
don't use $window.
This commit is contained in:
Chirayu Krishnappa 2013-07-23 11:02:33 -07:00
parent dfa83475a5
commit 7e49d37a98
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/ng/urlUtils.js
View file

@ -1,9 +1,14 @@
'use strict';
function $$UrlUtilsProvider() {
this.$get = ['$window', '$document', function($window, $document) {
this.$get = ['$document', function($document) {
var urlParsingNode = $document[0].createElement("a"),
originUrl = resolve($window.location.href, true);
// NOTE: The usage of window instead of $window here is deliberate. When the browser
// resolves a URL for XHR, it doesn't know about any mocked $window. $$urlUtils
// resolves URLs just as the browser would. Using $window here would confuse the
// isSameOrigin check causing unexpected failures. We avoid that by using the real window
// object.
originUrl = resolve(window.location.href, true);
/**
* @description