Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-05-10 07:44:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix🆖repeater - fix $position when collection size changes

Browse source
This commit is contained in:
Misko Hevery 2011-06-22 14:30:56 -07:00 committed by Igor Minar
parent 8e880fcb77
commit 9ec45ad5c4
3 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -10,6 +10,7 @@
### Bug Fixes ### Bug Fixes
- Number filter would return incorrect value when fractional part had leading zeros. - Number filter would return incorrect value when fractional part had leading zeros.
- Issue #399: return unsorted array if no predicate - Issue #399: return unsorted array if no predicate
- Fixed issues with incorrect value of $position in ng:repeat when collection size changes
### Breaking changes ### Breaking changes

3
src/widgets.js
View file

@ -1143,6 +1143,9 @@ angularWidget('@ng:repeat', function(expression, element){
childScope[valueIdent] = collection[key]; childScope[valueIdent] = collection[key];
if (keyIdent) childScope[keyIdent] = key; if (keyIdent) childScope[keyIdent] = key;
lastIterElement = childScope.$element; lastIterElement = childScope.$element;
childScope.$position = index == 0
? 'first'
: (index == collectionLength - 1 ? 'last' : 'middle');
childScope.$eval(); childScope.$eval();
} else { } else {
// grow children // grow children

6
test/widgetsSpec.js
View file

@ -893,7 +893,11 @@ describe("widget", function(){
it('should expose iterator position as $position when iterating over arrays', function() { it('should expose iterator position as $position when iterating over arrays', function() {
var scope = compile('<ul><li ng:repeat="item in items" ' + var scope = compile('<ul><li ng:repeat="item in items" ' +
'ng:bind="item + \':\' + $position + \'|\'"></li></ul>'); 'ng:bind="item + \':\' + $position + \'|\'"></li></ul>');
scope.items = ['misko', 'shyam', 'doug', 'frodo']; scope.items = ['misko', 'shyam', 'doug'];
scope.$eval();
expect(element.text()).toEqual('misko:first|shyam:middle|doug:last|');
scope.items.push('frodo');
scope.$eval(); scope.$eval();
expect(element.text()).toEqual('misko:first|shyam:middle|doug:middle|frodo:last|'); expect(element.text()).toEqual('misko:first|shyam:middle|doug:middle|frodo:last|');
}); });