mirror of
https://github.com/Hopiu/angular.js.git
synced 2026-03-16 23:30:23 +00:00
fix(input): Support form auto complete on modern browser
Although modern browser support the "input" event, they still only fire the "change" event when they auto complete form elements other than the currently selected one. Related to #1460
This commit is contained in:
parent
84e0eea164
commit
a090400f09
2 changed files with 29 additions and 3 deletions
|
|
@ -449,15 +449,15 @@ function textInputType(scope, element, attr, ctrl, $sniffer, $browser) {
|
|||
deferListener();
|
||||
});
|
||||
|
||||
// if user paste into input using mouse, we need "change" event to catch it
|
||||
element.on('change', listener);
|
||||
|
||||
// if user modifies input value using context menu in IE, we need "paste" and "cut" events to catch it
|
||||
if ($sniffer.hasEvent('paste')) {
|
||||
element.on('paste cut', deferListener);
|
||||
}
|
||||
}
|
||||
|
||||
// if user paste into input using mouse on older browser
|
||||
// or form autocomplete on newer browser, we need "change" event to catch it
|
||||
element.on('change', listener);
|
||||
|
||||
ctrl.$render = function() {
|
||||
element.val(ctrl.$isEmpty(ctrl.$viewValue) ? '' : ctrl.$viewValue);
|
||||
|
|
|
|||
|
|
@ -468,6 +468,32 @@ describe('input', function() {
|
|||
expect(scope.name).toEqual('adam');
|
||||
});
|
||||
|
||||
describe('"change" event', function() {
|
||||
function assertBrowserSupportsChangeEvent(inputEventSupported) {
|
||||
// Force browser to report a lack of an 'input' event
|
||||
$sniffer.hasEvent = function(eventName) {
|
||||
if (eventName === 'input' && !inputEventSupported) {
|
||||
return false;
|
||||
}
|
||||
return true;
|
||||
};
|
||||
compileInput('<input type="text" ng-model="name" name="alias" />');
|
||||
|
||||
inputElm.val('mark');
|
||||
browserTrigger(inputElm, 'change');
|
||||
expect(scope.name).toEqual('mark');
|
||||
}
|
||||
|
||||
it('should update the model event if the browser does not support the "input" event',function() {
|
||||
assertBrowserSupportsChangeEvent(false);
|
||||
});
|
||||
|
||||
it('should update the model event if the browser supports the "input" ' +
|
||||
'event so that form auto complete works',function() {
|
||||
assertBrowserSupportsChangeEvent(true);
|
||||
});
|
||||
});
|
||||
|
||||
describe('"paste" and "cut" events', function() {
|
||||
beforeEach(function() {
|
||||
// Force browser to report a lack of an 'input' event
|
||||
|
|
|
|||
Loading…
Reference in a new issue