mirror of
https://github.com/Hopiu/angular.js.git
synced 2026-03-16 23:30:23 +00:00
chore(dump): remove dead code
This code is not being used any more and the test is now failing due to Karma changes. Karma used to expose window.dump but that changed recently and that's why our build is now failing. I'm removing the code and test, but we still need to figure out how to route window.dump through angular.mock.dump, but that will have to be a separate commit.
This commit is contained in:
parent
683fd713c4
commit
acb6b75fe9
2 changed files with 2 additions and 23 deletions
20
src/ngMock/angular-mocks.js
vendored
20
src/ngMock/angular-mocks.js
vendored
|
|
@ -800,7 +800,7 @@ angular.mock.dump = function(object) {
|
|||
</pre>
|
||||
*
|
||||
* Now we setup the mock backend and create the test specs.
|
||||
*
|
||||
*
|
||||
<pre>
|
||||
// testing controller
|
||||
describe('MyController', function() {
|
||||
|
|
@ -856,7 +856,7 @@ angular.mock.dump = function(object) {
|
|||
it('should send auth header', function() {
|
||||
var controller = createController();
|
||||
$httpBackend.flush();
|
||||
|
||||
|
||||
$httpBackend.expectPOST('/add-msg.py', undefined, function(headers) {
|
||||
// check if the header was send, if it wasn't the expectation won't
|
||||
// match the request and the test will fail
|
||||
|
|
@ -1642,22 +1642,6 @@ angular.mock.clearDataCache = function() {
|
|||
};
|
||||
|
||||
|
||||
window.jstestdriver && (function(window) {
|
||||
/**
|
||||
* Global method to output any number of objects into JSTD console. Useful for debugging.
|
||||
*/
|
||||
window.dump = function() {
|
||||
var args = [];
|
||||
angular.forEach(arguments, function(arg) {
|
||||
args.push(angular.mock.dump(arg));
|
||||
});
|
||||
jstestdriver.console.log.apply(jstestdriver.console, args);
|
||||
if (window.console) {
|
||||
window.console.log.apply(window.console, args);
|
||||
}
|
||||
};
|
||||
})(window);
|
||||
|
||||
|
||||
window.jasmine && (function(window) {
|
||||
|
||||
|
|
|
|||
5
test/ngMock/angular-mocksSpec.js
vendored
5
test/ngMock/angular-mocksSpec.js
vendored
|
|
@ -353,11 +353,6 @@ describe('ngMock', function() {
|
|||
expect(d($rootScope)).toMatch(/Scope\(.*\): \{/);
|
||||
expect(d($rootScope)).toMatch(/{"abc":"123"}/);
|
||||
}));
|
||||
|
||||
|
||||
it('should be published on window', function(){
|
||||
expect(window.dump instanceof Function).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue