Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-03-16 23:30:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix:scope - reintroduce support for eager services

Browse source 
8cad231 broke $eager services

Problem is that the injector.eager function is not invoked when a new scope
is created. Added a test to make sure service is eagerly instantiated.

Closes #403
This commit is contained in:
Di Peng 2011-06-22 11:15:42 -07:00 committed by Igor Minar
parent 65b6e48742
commit bad62d87a1
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Scope.js
View file

@ -525,7 +525,7 @@ function createScope(parent, providers, instanceCache) {
* @param {string} serviceId String ID of the service to return.
* @returns {*} Value, object or function returned by the service factory function if any.
*/
instance.$service = createInjector(instance, providers, instanceCache);
(instance.$service = createInjector(instance, providers, instanceCache)).eager();
}
$log = instance.$service('$log');

7
test/AngularSpec.js
View file

@ -516,6 +516,13 @@ describe('angular', function(){
angular.service('svc2', function(svc1) { return 'svc2-' + svc1; });
expect(angular.scope().$service('svc2')).toEqual('svc2-svc1');
});
it('should eagerly instantiate a service if $eager is true', function() {
var log = [];
angular.service('svc1', function() { log.push('svc1'); }, {$eager: true});
angular.scope();
expect(log).toEqual(['svc1']);
});
});
describe('isDate', function() {