Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-05-08 14:54:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix($resource): action defaults should override resource defaults

Browse source 
defaults definned per action should take precedence over defaults
defined for the whole resource.

This is potentialy a BREAKING CHANGE in case someone relied on the buggy
behavior.
This commit is contained in:
Marcello Nuccio 2011-09-02 15:50:10 +02:00 committed by Igor Minar
parent 2e9fed7b6c
commit bf5e5f7bc9
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Resource.js
View file

@ -109,7 +109,7 @@ ResourceFactory.prototype = {
var value = this instanceof Resource ? this : (action.isArray ? [] : new Resource(data)); var value = this instanceof Resource ? this : (action.isArray ? [] : new Resource(data));
self.xhr( self.xhr(
action.method, action.method,
route.url(extend({}, action.params || {}, extractParams(data), params)), route.url(extend({}, extractParams(data), action.params || {}, params)),
data, data,
function(status, response) { function(status, response) {
if (response) { if (response) {

9
test/ResourceSpec.js
View file

@ -75,6 +75,15 @@ describe("resource", function() {
nakedExpect(item).toEqual({id:'abc'}); nakedExpect(item).toEqual({id:'abc'});
}); });
it("should build resource with action default param overriding default param", function(){
xhr.expectGET('/Customer/123').respond({id:'abc'});
var TypeItem = resource.route('/:type/:typeId', {type: 'Order'},
{get: {method: 'GET', params: {type: 'Customer'}}});
var item = TypeItem.get({typeId:123});
xhr.flush();
nakedExpect(item).toEqual({id:'abc'});
});
it("should create resource", function(){ it("should create resource", function(){
xhr.expectPOST('/CreditCard', {name:'misko'}).respond({id:123, name:'misko'}); xhr.expectPOST('/CreditCard', {name:'misko'}).respond({id:123, name:'misko'});