Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-05-20 04:11:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

$location.updateHash should not preserve hashSearch when hashSearch is undefined

Browse source
This commit is contained in:
Igor Minar 2011-02-04 09:11:18 -08:00
parent a6c45c3e66
commit bf8013ad57
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/services.js
View file

@ -172,8 +172,7 @@ angularServiceInject("$location", function($browser) {
if (isString(path)) { if (isString(path)) {
hash.hashPath = path; hash.hashPath = path;
if (isDefined(search)) hash.hashSearch = search || {};
hash.hashSearch = search;
} else } else
hash.hashSearch = path; hash.hashSearch = path;

8
test/servicesSpec.js
View file

@ -314,6 +314,14 @@ describe("service", function(){
expect($location.hashPath).toEqual('path'); expect($location.hashPath).toEqual('path');
}); });
it('should reset hashSearch when updating with a single string', function() {
$location.updateHash({foo:'bar'}); //set some initial state for hashSearch
$location.updateHash('path');
expect($location.hashPath).toEqual('path');
expect($location.hashSearch).toEqual({});
});
it('should accept single object argument to update search', function() { it('should accept single object argument to update search', function() {
$location.updateHash({a: 'b'}); $location.updateHash({a: 'b'});
expect($location.hash).toEqual('?a=b'); expect($location.hash).toEqual('?a=b');