Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-03-20 00:10:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix($q): $q.reject should forward callbacks if missing

Browse source 
$q.reject('some reason').then() should not blow up, but correctly
forward the callbacks instead.

Closes #845
This commit is contained in:
Igor Minar 2012-04-02 10:10:46 -07:00
parent 59fa40ec0e
commit c0b78478a0
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/ng/q.js
View file

@ -274,7 +274,7 @@ function qFactory(nextTick, exceptionHandler) {
then: function(callback, errback) {
var result = defer();
nextTick(function() {
result.resolve(errback(reason));
result.resolve((errback || defaultErrback)(reason));
});
return result.promise;
}

8
test/ng/qSpec.js
View file

@ -480,6 +480,14 @@ describe('q', function() {
syncResolve(deferred, rejectedPromise);
expect(log).toEqual(['error(Error: not gonna happen)']);
});
it('should return a promise that forwards callbacks if the callbacks are missing', function() {
var rejectedPromise = q.reject('rejected');
promise.then(success(), error());
syncResolve(deferred, rejectedPromise.then());
expect(log).toEqual(['error(rejected)']);
});
});