improve error handling with elements

scenario/perf.html

@@ -8,7 +8,7 @@
       PerfCntl.prototype = {
         createItems: function(){
           var items = [];
-          for ( var i = 0; i < 100; i++) {
+          for ( var i = 0; i < 1000; i++) {
             var item = {
               name: "" + Math.random(),
               parts: [Math.random(), Math.random()]

src/Angular.js

@@ -291,12 +291,15 @@ function elementError(element, type, error) {
   while (!isRenderableElement(element)) {
     element = element.parent() || jqLite(document.body);
   }
-  if (error) {
+  if (element[0]['$NG_ERROR'] !== error) {
-    element.addClass(type);
+    element[0]['$NG_ERROR'] = error;
-    element.attr(type, error);
+    if (error) {
-  } else {
+      element.addClass(type);
-    element.removeClass(type);
+      element.attr(type, error);
-    element.removeAttr(type);
+    } else {
+      element.removeClass(type);
+      element.removeAttr(type);
+    }
   }
 }
 

src/Browser.js

@@ -3,7 +3,7 @@
 //////////////////////////////
 
 function Browser(location, document) {
-  this.delay = 25;
+  this.delay = 50;
   this.expectedUrl = location.href;
   this.urlListeners = [];
   this.hoverListener = noop;

src/Scope.js

@@ -53,14 +53,8 @@ function expressionCompile(exp){
     parser.assertAllConsumed();
     compileCache[exp] = expFn;
   }
-  return parserNewScopeAdapter(expFn);
-}
-
-// return expFn
-// TODO(remove this hack)
-function parserNewScopeAdapter(fn) {
   return function(){
-    return fn(this);
+    return expFn(this);
   };
 }
 

src/apis.js

@@ -296,8 +296,9 @@ var angularFunction = {
     if (isFunction(expression)){
       return expression;
     } else if (expression){
+      var fn = expressionCompile(expression);
       return function($) {
-        return expressionCompile(expression).apply($);
+        return fn.apply($);
       };
     } else {
       return identity;