Hopiu/angular.js
1
0
Fork 0
mirror of https://github.com/Hopiu/angular.js.git synced 2026-03-18 15:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

encode $resource query params using encodeURIComponent

Browse source
This commit is contained in:
Igor Minar 2011-03-18 10:31:28 -07:00
parent 885c3ad5dd
commit e1d122a4b7
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Resource.js
View file

@ -26,7 +26,7 @@ Route.prototype = {
var query = []; var query = [];
forEachSorted(params, function(value, key){ forEachSorted(params, function(value, key){
if (!self.urlParams[key]) { if (!self.urlParams[key]) {
query.push(encodeUriSegment(key) + '=' + encodeUriSegment(value)); query.push(encodeURIComponent(key) + '=' + encodeURIComponent(value));
} }
}); });
url = url.replace(/\/*$/, ''); url = url.replace(/\/*$/, '');

8
test/ResourceSpec.js
View file

@ -55,10 +55,16 @@ describe("resource", function() {
//buzz api which uses @self //buzz api which uses @self
var R = resource.route('/Path/:a'); var R = resource.route('/Path/:a');
xhr.expectGET('/Path/doh@foo?bar=baz@1').respond({}); xhr.expectGET('/Path/doh@foo?bar=baz%401').respond({});
R.get({a: 'doh@foo', bar: 'baz@1'}); R.get({a: 'doh@foo', bar: 'baz@1'});
}); });
it('should encode & in url params', function() {
var R = resource.route('/Path/:a');
xhr.expectGET('/Path/doh&foo?bar=baz%261').respond({});
R.get({a: 'doh&foo', bar: 'baz&1'});
});
it("should build resource with default param", function(){ it("should build resource with default param", function(){
xhr.expectGET('/Order/123/Line/456.visa?minimum=0.05').respond({id:'abc'}); xhr.expectGET('/Order/123/Line/456.visa?minimum=0.05').respond({id:'abc'});
var LineItem = resource.route('/Order/:orderId/Line/:id:verb', {orderId: '123', id: '@id.key', verb:'.visa', minimum:0.05}); var LineItem = resource.route('/Order/:orderId/Line/:id:verb', {orderId: '123', id: '@id.key', verb:'.visa', minimum:0.05});