mirror of
https://github.com/Hopiu/angular.js.git
synced 2026-03-17 07:40:22 +00:00
f3de5b6eac
Change the a directive to link and hookup a click event only when there is no href or name in the template element. In a large Google app, this results in about 800 fewer registrations, saving a small but measurable amount of time and memory. Closes #5362
87 lines
2.1 KiB
JavaScript
87 lines
2.1 KiB
JavaScript
'use strict';
|
|
|
|
describe('a', function() {
|
|
var element, $compile, $rootScope;
|
|
|
|
|
|
beforeEach(inject(function(_$compile_, _$rootScope_) {
|
|
$compile = _$compile_;
|
|
$rootScope = _$rootScope_;
|
|
}));
|
|
|
|
|
|
afterEach(function(){
|
|
dealoc(element);
|
|
});
|
|
|
|
|
|
it('should prevent default action to be executed when href is empty', function() {
|
|
var orgLocation = document.location.href,
|
|
preventDefaultCalled = false,
|
|
event;
|
|
|
|
element = $compile('<a href="">empty link</a>')($rootScope);
|
|
|
|
if (msie < 9) {
|
|
|
|
event = document.createEventObject();
|
|
expect(event.returnValue).not.toBeDefined();
|
|
element[0].fireEvent('onclick', event);
|
|
expect(event.returnValue).toEqual(false);
|
|
|
|
} else {
|
|
|
|
event = document.createEvent('MouseEvent');
|
|
event.initMouseEvent(
|
|
'click', true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
|
|
|
|
event.preventDefaultOrg = event.preventDefault;
|
|
event.preventDefault = function() {
|
|
preventDefaultCalled = true;
|
|
if (this.preventDefaultOrg) this.preventDefaultOrg();
|
|
};
|
|
|
|
element[0].dispatchEvent(event);
|
|
|
|
expect(preventDefaultCalled).toEqual(true);
|
|
}
|
|
|
|
expect(document.location.href).toEqual(orgLocation);
|
|
});
|
|
|
|
|
|
it('should prevent IE for changing text content when setting attribute', function() {
|
|
// see issue #1949
|
|
element = jqLite('<a href="">hello@you</a>');
|
|
$compile(element);
|
|
element.attr('href', 'bye@me');
|
|
|
|
expect(element.text()).toBe('hello@you');
|
|
});
|
|
|
|
|
|
it('should not link and hookup an event if href is present at compile', function() {
|
|
var jq = jQuery || jqLite;
|
|
element = jq('<a href="//a.com">hello@you</a>');
|
|
var linker = $compile(element);
|
|
|
|
spyOn(jq.prototype, 'on');
|
|
|
|
linker($rootScope);
|
|
|
|
expect(jq.prototype.on).not.toHaveBeenCalled();
|
|
});
|
|
|
|
|
|
it('should not link and hookup an event if name is present at compile', function() {
|
|
var jq = jQuery || jqLite;
|
|
element = jq('<a name="bobby">hello@you</a>');
|
|
var linker = $compile(element);
|
|
|
|
spyOn(jq.prototype, 'on');
|
|
|
|
linker($rootScope);
|
|
|
|
expect(jq.prototype.on).not.toHaveBeenCalled();
|
|
});
|
|
});
|