angular.js/test/ng/controllerSpec.js
Peter Bacon Darwin 7a586e5c19 fix(*): protect calls to hasOwnProperty in public API
Objects received from outside AngularJS may have had their `hasOwnProperty`
method overridden with something else. In cases where we can do this without
incurring a performance penalty we call directly on Object.prototype.hasOwnProperty
to ensure that we use the correct method.

Also, we have some internal hash objects, where the keys for the map are provided
from outside AngularJS. In such cases we either prevent `hasOwnProperty` from
being used as a key or provide some other way of preventing our objects from
having their `hasOwnProperty` overridden.

BREAKING CHANGE: Inputs with name equal to "hasOwnProperty" are not allowed inside
form or ngForm directives.

Before, inputs whose name was "hasOwnProperty" were quietly ignored and not added
to the scope.  Now a badname exception is thrown.

Using "hasOwnProperty" for an input name would be very unusual and bad practice.
Either do not include such an input in a `form` or `ngForm` directive or change
the name of the input.

Closes #3331
2013-10-07 09:01:13 -07:00

145 lines
4 KiB
JavaScript

'use strict';
describe('$controller', function() {
var $controllerProvider, $controller;
beforeEach(module(function(_$controllerProvider_) {
$controllerProvider = _$controllerProvider_;
}));
beforeEach(inject(function(_$controller_) {
$controller = _$controller_;
}));
describe('provider', function() {
it('should allow registration of controllers', function() {
var FooCtrl = function($scope) { $scope.foo = 'bar' },
scope = {},
ctrl;
$controllerProvider.register('FooCtrl', FooCtrl);
ctrl = $controller('FooCtrl', {$scope: scope});
expect(scope.foo).toBe('bar');
expect(ctrl instanceof FooCtrl).toBe(true);
});
it('should allow registration of map of controllers', function() {
var FooCtrl = function($scope) { $scope.foo = 'foo' },
BarCtrl = function($scope) { $scope.bar = 'bar' },
scope = {},
ctrl;
$controllerProvider.register({FooCtrl: FooCtrl, BarCtrl: BarCtrl} );
ctrl = $controller('FooCtrl', {$scope: scope});
expect(scope.foo).toBe('foo');
expect(ctrl instanceof FooCtrl).toBe(true);
ctrl = $controller('BarCtrl', {$scope: scope});
expect(scope.bar).toBe('bar');
expect(ctrl instanceof BarCtrl).toBe(true);
});
it('should allow registration of controllers annotated with arrays', function() {
var FooCtrl = function($scope) { $scope.foo = 'bar' },
scope = {},
ctrl;
$controllerProvider.register('FooCtrl', ['$scope', FooCtrl]);
ctrl = $controller('FooCtrl', {$scope: scope});
expect(scope.foo).toBe('bar');
expect(ctrl instanceof FooCtrl).toBe(true);
});
it('should throw an exception if a controller is called "hasOwnProperty"', function () {
expect(function() {
$controllerProvider.register('hasOwnProperty', function($scope) {});
}).toThrowMinErr('ng', 'badname', "hasOwnProperty is not a valid controller name");
});
});
it('should return instance of given controller class', function() {
var MyClass = function() {},
ctrl = $controller(MyClass);
expect(ctrl).toBeDefined();
expect(ctrl instanceof MyClass).toBe(true);
});
it('should inject arguments', inject(function($http) {
var MyClass = function($http) {
this.$http = $http;
};
var ctrl = $controller(MyClass);
expect(ctrl.$http).toBe($http);
}));
it('should inject given scope', function() {
var MyClass = function($scope) {
this.$scope = $scope;
};
var scope = {},
ctrl = $controller(MyClass, {$scope: scope});
expect(ctrl.$scope).toBe(scope);
});
it('should instantiate controller defined on window', inject(function($window) {
var scope = {};
var Foo = function() {};
$window.a = {Foo: Foo};
var foo = $controller('a.Foo', {$scope: scope});
expect(foo).toBeDefined();
expect(foo instanceof Foo).toBe(true);
}));
describe('ctrl as syntax', function() {
it('should publish controller instance into scope', function() {
var scope = {};
$controllerProvider.register('FooCtrl', function() { this.mark = 'foo'; });
var foo = $controller('FooCtrl as foo', {$scope: scope});
expect(scope.foo).toBe(foo);
expect(scope.foo.mark).toBe('foo');
});
it('should allow controllers with dots', function() {
var scope = {};
$controllerProvider.register('a.b.FooCtrl', function() { this.mark = 'foo'; });
var foo = $controller('a.b.FooCtrl as foo', {$scope: scope});
expect(scope.foo).toBe(foo);
expect(scope.foo.mark).toBe('foo');
});
it('should throw an error if $scope is not provided', function() {
$controllerProvider.register('a.b.FooCtrl', function() { this.mark = 'foo'; });
expect(function() {
$controller('a.b.FooCtrl as foo');
}).toThrowMinErr("$controller", "noscp", "Cannot export controller 'a.b.FooCtrl' as 'foo'! No $scope object provided via `locals`.");
});
});
});