mirror of
https://github.com/Hopiu/angular.js.git
synced 2026-03-17 15:40:22 +00:00
7a586e5c19
Objects received from outside AngularJS may have had their `hasOwnProperty` method overridden with something else. In cases where we can do this without incurring a performance penalty we call directly on Object.prototype.hasOwnProperty to ensure that we use the correct method. Also, we have some internal hash objects, where the keys for the map are provided from outside AngularJS. In such cases we either prevent `hasOwnProperty` from being used as a key or provide some other way of preventing our objects from having their `hasOwnProperty` overridden. BREAKING CHANGE: Inputs with name equal to "hasOwnProperty" are not allowed inside form or ngForm directives. Before, inputs whose name was "hasOwnProperty" were quietly ignored and not added to the scope. Now a badname exception is thrown. Using "hasOwnProperty" for an input name would be very unusual and bad practice. Either do not include such an input in a `form` or `ngForm` directive or change the name of the input. Closes #3331
81 lines
2.4 KiB
JavaScript
81 lines
2.4 KiB
JavaScript
'use strict';
|
|
|
|
describe('module loader', function() {
|
|
var window;
|
|
|
|
beforeEach(function () {
|
|
window = {};
|
|
setupModuleLoader(window);
|
|
});
|
|
|
|
|
|
it('should set up namespace', function() {
|
|
expect(window.angular).toBeDefined();
|
|
expect(window.angular.module).toBeDefined();
|
|
});
|
|
|
|
|
|
it('should not override existing namespace', function() {
|
|
var angular = window.angular;
|
|
var module = angular.module;
|
|
|
|
setupModuleLoader(window);
|
|
expect(window.angular).toBe(angular);
|
|
expect(window.angular.module).toBe(module);
|
|
});
|
|
|
|
|
|
it('should record calls', function() {
|
|
var otherModule = window.angular.module('other', []);
|
|
otherModule.config('otherInit');
|
|
|
|
var myModule = window.angular.module('my', ['other'], 'config');
|
|
|
|
expect(myModule.
|
|
provider('sk', 'sv').
|
|
factory('fk', 'fv').
|
|
service('a', 'aa').
|
|
value('k', 'v').
|
|
filter('f', 'ff').
|
|
directive('d', 'dd').
|
|
controller('ctrl', 'ccc').
|
|
config('init2').
|
|
constant('abc', 123).
|
|
run('runBlock')).toBe(myModule);
|
|
|
|
expect(myModule.requires).toEqual(['other']);
|
|
expect(myModule._invokeQueue).toEqual([
|
|
['$provide', 'constant', ['abc', 123] ],
|
|
['$injector', 'invoke', ['config'] ],
|
|
['$provide', 'provider', ['sk', 'sv'] ],
|
|
['$provide', 'factory', ['fk', 'fv'] ],
|
|
['$provide', 'service', ['a', 'aa'] ],
|
|
['$provide', 'value', ['k', 'v'] ],
|
|
['$filterProvider', 'register', ['f', 'ff'] ],
|
|
['$compileProvider', 'directive', ['d', 'dd'] ],
|
|
['$controllerProvider', 'register', ['ctrl', 'ccc']],
|
|
['$injector', 'invoke', ['init2'] ]
|
|
]);
|
|
expect(myModule._runBlocks).toEqual(['runBlock']);
|
|
});
|
|
|
|
|
|
it('should allow module redefinition', function() {
|
|
expect(window.angular.module('a', [])).not.toBe(window.angular.module('a', []));
|
|
});
|
|
|
|
|
|
it('should complain of no module', function() {
|
|
expect(function() {
|
|
window.angular.module('dontExist');
|
|
}).toThrowMinErr("$injector", "nomod", "Module 'dontExist' is not available! You either misspelled the module name " +
|
|
"or forgot to load it. If registering a module ensure that you specify the dependencies as the second " +
|
|
"argument.");
|
|
});
|
|
|
|
it('should complain if a module is called "hasOwnProperty', function() {
|
|
expect(function() {
|
|
window.angular.module('hasOwnProperty', []);
|
|
}).toThrowMinErr('ng','badname', "hasOwnProperty is not a valid module name");
|
|
});
|
|
});
|