Mark Otto
365c9753f8
Ensure alignment of modal dismiss when no .modal-title is present
2017-08-10 22:45:48 -07:00
Mark Otto
09019a8ecd
Set explicit text-align on <body> element so we can use inherit to override the default <th> text-align value
2017-08-10 22:43:50 -07:00
Nathan Woltman
f95282c27e
Fix border on input group elements and custom form inputs
...
c3e4cbd changed the border of input elements to be translucent. This commit makes
input group elements and custom form inputs follow the same pattern.
2017-08-10 22:41:21 -07:00
Mark Otto
1846ab34f6
300, not light
2017-08-10 22:40:02 -07:00
Mark Otto
1e38b45980
Add $font-weight-light var
2017-08-10 22:40:02 -07:00
Mark Otto
ed4f5778a9
Add .font-weight-light class, add !important to the classes
2017-08-10 22:40:02 -07:00
Mark Otto
006590ed9a
Remove broken CSS that tried to reset the absolute positioning when there was no text
2017-08-10 22:36:35 -07:00
Mark Otto
3fbdedbf22
Add basic property-value utils for position
2017-08-10 22:35:38 -07:00
Mark Otto
35f80bb12e
bump to beta
2017-08-10 20:56:35 -07:00
lucascono
08b89972c5
Fix the min breakpoint in media-breakpoint-between
2017-08-08 00:07:42 -07:00
Mark Otto
2cd2301e7a
Add .bg-white and .border-white
2017-08-07 22:06:53 -07:00
Patrick Yeo
cd3507aba6
Dropup dropdown-menu should have margin on the bottom instead of top
2017-08-04 15:17:50 -07:00
Patrick Yeo
0501b029f5
( #22414 ) Rename for consistency $dropdown-margin-top to $dropdown-spacer
2017-08-04 15:17:50 -07:00
Mark Otto
73040d4311
fix navbar alignment for never expand situations
2017-08-04 15:15:25 -07:00
Mark Otto
987ac632b5
given width: 100% is always on a container now and it's constrained by max-width, we can remove our navbar changes from #21722 and #22383
2017-08-04 15:14:24 -07:00
Chirag Modi
b2712048ce
make changes as per suggestion in #23100
2017-07-18 11:48:59 +05:30
Chirag Modi
a52a1fbb13
remove change which set from variable and make those in container class
2017-07-18 11:44:56 +05:30
Chirag Modi
f05bd63d8e
fixed issue #23100
2017-07-17 13:29:49 +05:30
Patrick Yeo
696b2bee11
( #22414 ) Rename for consistency $custom-checkbox-border-radius, $custom-checkbox-icon-checked, $custom-checkbox-indeterminate-bg, $custom-checkbox-icon-indeterminate, $custom-checkbox-indeterminate-box-shadow, $custom-radio-border-radius, $custom-radio-icon-checked to $custom-checkbox-indicator-border-radius, $custom-checkbox-indicator-icon-checked, $custom-checkbox-indicator-indeterminate-bg, $custom-checkbox-indicator-icon-indeterminate, $custom-checkbox-indicator-indeterminate-box-shadow, $custom-radio-indicator-border-radius, $custom-radio-indicator-icon-checked, respectively
2017-07-16 12:36:26 -07:00
Patrick H. Lauke
7a781b2ae0
Remove ::first-letter and ::first-line selectors from print styles
...
Bootstrap itself doesn't use any `::first-letter` or `::first-line`
styles. These selectors also cause(d) problems in IE11 (see
https://github.com/h5bp/html5-boilerplate/pull/1799 ) and currently cause
a nasty rendering bug in Chrome where the first letter is vertically
shifted (see https://github.com/twbs/bootstrap/issues/21771 )
As h5bp has now removed these as well, no need to keep and comment them
out. See https://github.com/h5bp/html5-boilerplate/issues/1961 /
https://github.com/h5bp/html5-boilerplate/pull/1962
2017-07-11 19:51:21 +01:00
Patrick H. Lauke
edae6a2e1d
Remove box-shadow from .btn-link:focus ( #22998 )
...
When focused, these buttons styled as links still give good visible focus indication through the underline, so this should not be a concern. Closes #22655
2017-07-05 10:54:26 +02:00
Mark Otto
de78b71bab
fixes #22981
2017-07-03 19:04:31 -07:00
Mark Otto
3b08beb37a
follow up to 4e067f722
2017-07-01 23:40:51 -07:00
Mark Otto
7bce8648ed
Merge branch 'v4-dev' of https://github.com/twbs/bootstrap into v4-dev
2017-07-01 23:36:11 -07:00
Mark Otto
4e067f7229
remove unused $list-group-color variable; it should naturally inherit from the body
2017-07-01 23:35:57 -07:00
Mark Otto
f282a88475
update comment
2017-07-01 23:25:28 -07:00
Mark Otto
4b6d2c0b3c
put button active bg and border in the mixin params for more customization options
2017-07-01 23:25:28 -07:00
Mark Otto
e7ae1d9069
match btn transition to input
2017-07-01 23:10:01 -07:00
Mark Otto
7085988f06
doh, we already have that above
2017-07-01 23:05:51 -07:00
Mark Otto
6f073edc79
Add .text-truncate class. We already had a mixin and documented the class, so this fixes that.
2017-07-01 23:05:51 -07:00
Mark Otto
4b84614e7f
Redo the "responsive helpers" files
...
- Moves the embed SCSS to the utilities subfolder
- Separate the floats from the embed docs
- Rename embed docs from responsive helpers to embeds
2017-07-01 23:05:51 -07:00
Mark Otto
11e18af1b6
remove some unused vars, restore table-active variant
2017-07-01 22:57:19 -07:00
Mark Otto
3e2318cf7c
badge variants are generated from -colors Sass map
2017-07-01 22:57:19 -07:00
Mark Otto
848a746a89
button variants are generated from -colors Sass map
2017-07-01 22:57:19 -07:00
Mark Otto
97a5bc4870
no xs sizes being used
2017-07-01 22:57:19 -07:00
Mark Otto
3603088454
Restore .text-muted
2017-07-01 19:01:58 -07:00
Mark Otto
2bf4de0698
Update carousel display settings
...
Use `display: block` since we're not really using any flex styles on the `.carousel-items` (only their controls and indicators). For the indicators, since moving to `width`, our indicators grow to fill available space, so we need to change `flex: 1 0 auto` to `flex: 0 1 auto` to prevent that.
2017-07-01 16:59:16 -07:00
Mark Otto
75156f419a
using max-width in flex: 1 0 auto; in ie11 offsets the center-aligned contents
2017-07-01 11:21:20 -07:00
Mark Otto
2d4534e112
use @supports to apply transform3d to those who can do it, then provide a non-3d fallback to ie11
2017-07-01 11:21:20 -07:00
Mark Otto
88b9e558fb
clip to border-box, update overlay
2017-06-30 15:28:50 -07:00
Mark Otto
9a2b202e8e
add a bg-transparent to override bgs
2017-06-30 15:23:36 -07:00
Mark Otto
2feebccf24
make card headers and footers translucent
2017-06-30 15:23:36 -07:00
Mark Otto
180d78c013
Drop .card-{color} modifiers for .bg-{color}, .text-{color}, and .border-{color} utilities
2017-06-30 15:23:36 -07:00
Mark Otto
45722e94ac
Drop .blockquote-reverse, replace with text utils, and redesign blockquote to not have a border
2017-06-30 15:04:56 -07:00
Mark Otto
16781be021
drop the mixins
2017-06-30 11:44:09 -07:00
Mark Otto
deeae4f820
Update _grid-framework.scss
2017-06-30 11:44:09 -07:00
Mark Otto
4982926dcf
Drop offsets and push/pull for new order variants
2017-06-30 11:44:09 -07:00
Mark Otto
d30b5b120e
remove unused mixin, fix variable
2017-06-30 09:01:39 -07:00
Mark Otto
b013b987b0
remove grid gutter sass map as it's output css was all jacked up
2017-06-30 09:01:39 -07:00
Mark Otto
ac00c73ab5
update comment
2017-06-29 23:17:18 -07:00
Mark Otto
964e06800a
Drop the old $gray- variables for the new color range
2017-06-29 23:15:27 -07:00
Mark Otto
a21a9f341b
add map function for grays
2017-06-29 23:06:46 -07:00
Mark Otto
6fbceb2f70
remove $state-vars now
2017-06-28 09:38:27 -07:00
Mark Otto
0f232de9d7
move table variants to use sass map
2017-06-28 09:36:27 -07:00
Mark Otto
3e0375e03b
move list group variants to be generated from sass map
2017-06-28 09:29:59 -07:00
Mark Otto
91b587ad6a
remove now unused alert variant variables
2017-06-28 09:23:10 -07:00
Mark Otto
41f4ddbdb5
Merge branch 'v4-dev' into colors-redux
2017-06-26 15:17:48 -07:00
Mark Otto
0622a59897
fixes #22908
2017-06-26 07:59:20 -07:00
Mark Otto
9bfbee3503
add border color utilities
2017-06-25 18:39:14 -07:00
Mark Otto
6c595d2cc1
add theme-color-level function and interval so we can generate shades of colors
2017-06-25 18:31:03 -07:00
Mark Otto
9372eef9e1
rename .card-inverse to .card-dark, update docs to match
2017-06-25 18:30:24 -07:00
Mark Otto
36e482ed27
update navbars to rename .navbar-inverse to .navbar-dark, update all navbar examples and variables
2017-06-25 18:29:43 -07:00
Mark Otto
2392047a0c
update alert component to use theme sass map and add a ton of options in the process
2017-06-25 18:22:51 -07:00
Mark Otto
fc053ed096
update background utils
2017-06-25 18:16:37 -07:00
Mark Otto
aa83c4f417
update badges to use the theme colors sass map
2017-06-25 18:15:32 -07:00
Mark Otto
370e299c6b
modify contrast value
2017-06-25 18:11:16 -07:00
Mark Otto
b973fe6b94
update theme colors
2017-06-25 18:08:43 -07:00
Mark Otto
222eddda5e
Merge branch 'v4-dev' into colors-redux
2017-06-18 18:32:42 -07:00
obinnangini
532493e6ec
Updated flex-basis property to fix issue #18569 in .scss files
2017-06-18 18:17:48 -07:00
Mark Otto
1a23321fc0
Update _buttons.scss
2017-06-18 10:53:27 -07:00
Mark Otto
597e9f8618
remove - vars, update docs to generate from data yml files, update mixins, and generate card, button, bg, and color classes from the sass map
2017-06-18 02:57:16 -07:00
Mark Otto
74f1d002b4
Merge branch 'v4-dev' into colors-redux
2017-06-18 02:19:34 -07:00
Patrick Yeo
845320fe8c
@mixin pagination-size() doesn't apply line-height
2017-06-18 02:11:33 -07:00
Ken Paulsen
a47f373e82
Fix mixin media-breakpoint-only
...
Prevent mixin media-breakpoint-only from breaking when supplying the
first or last entry in $grid-breakpoints.
2017-06-18 02:08:11 -07:00
Mark Otto
d2508ec506
Update _borders.scss
2017-06-17 23:20:56 -07:00
Mark Otto
da2629907e
move from mixins and add important flag
2017-06-17 23:20:56 -07:00
Mark Otto
5476e636ce
limit active styles for nav-pills to immediate children
2017-06-17 22:40:07 -07:00
Mark Otto
1b722372a8
update comment
2017-06-17 20:25:35 -07:00
Mark Otto
60d8c8754f
wrap .sticky-top in supports query
2017-06-17 13:13:47 -07:00
Catalin Zalog
f640ec9662
Some .navbar .dropdown-menu optimisation ( #22776 )
2017-06-17 13:12:39 -07:00
Johann-S
af93db294b
Reset Popper.js styles for Dropdowns in navbar
2017-06-17 13:12:39 -07:00
Patrick Yeo
9f0929013e
( #22414 ) Rename for consistency $list-group-link-*-* to $list-group-action-*-*
2017-06-16 18:58:21 -07:00
Mark Otto
2ad2d71f66
add new color vars and maps
2017-06-15 11:16:27 -07:00
Mark Otto
c31d524998
add color contrast and map-get functions
2017-06-15 11:15:48 -07:00
Mark Otto
9c0e423008
Rename popover classes
...
Part of an update to align the naming schemes across our components.
- Renames .popover-title to .popover-header
- Renames .popover-content to .popover-body
Refs: #22092
2017-06-15 09:05:30 -07:00
Mark Otto
6c8c0aa4cf
Rename .card-block to .card-body to match nomenclature of modals
2017-06-15 09:05:16 -07:00
Mark Otto
e62b121226
Merge branch 'v4-dev' into rip-custom
2017-06-14 20:59:02 -07:00
Mark Otto
ac96ecbec5
rearrange, add comments
2017-06-14 20:55:00 -07:00
Mark Otto
5da5a38f0d
Move scss functions from top of variables to separate file, then import it into other build files
2017-06-14 20:55:00 -07:00
Mark Otto
5818374fdf
Merge branch 'v4-dev' into rip-custom
2017-06-14 20:45:31 -07:00
Patrick H. Lauke
ff5c75510d
Rename .form-control-static to .form-control-readonly-plain
2017-06-14 19:51:50 -07:00
Mark Otto
aa8c456a16
Remove the confusing _custom.scss file
2017-06-13 22:45:16 -07:00
Mark Otto
7e5085b407
move from .gutters-sm to .form-row to be super explicit about intended use case
2017-06-13 22:11:29 -07:00
Mark Otto
21b874d19d
Merge branch 'v4-dev' into form-tweaks
2017-06-13 20:15:42 -07:00
Patrick Yeo
d7867377d9
( Fixes #22414 ) Rename for consistency $custom-checkbox-radius, $custom-checkbox-checked-icon, $custom-checkbox-indeterminate-indicator-color, $custom-checkbox-indeterminate-icon, $custom-radio-radius, $custom-radio-checked-icon, $custom-select-sm-font-size, to $custom-checkbox-border-radius, $custom-checkbox-icon-checked, $custom-checkbox-indicator-indeterminate-color, $custom-checkbox-icon-indeterminate, $custom-radio-border-radius, $custom-radio-icon-checked, $custom-select-font-size-sm respectively
2017-06-13 19:22:49 -07:00
Patrick Yeo
a362d62d31
Rename $font-size-h* to $h*-font-size for consistency ( #22414 )
2017-06-13 08:46:29 -07:00
Patrick Yeo
c349f59174
Rename for consistency $table-sm-cell-padding, $table-bg-accent, $table-bg-hover, $table-bg-active, $table-inverse-bg-accent, $table-inverse-bg-hover to $table-cell-padding-sm, $table-accent-bg, $table-hover-bg, $table-active-bg, $table-inverse-accent-bg, $table-inverse-hover-bg, respectively ( #22414 )
2017-06-13 08:46:15 -07:00
Patrick Yeo
4cc21bbf74
( #22414 ) Rename for consistency $input-bg-disabled, $input-bg-focus, $input-border-color-focus, $input-box-shadow-focus, $input-color-focus, $input-color-placeholder to $input-disabled-bg, $input-focus-bg, $input-focus-border-color, $input-focus-box-shadow, $input-focus-color, $input-placeholder-color, respectively
2017-06-13 08:45:50 -07:00
Patrick Yeo
2317b7fc96
( #22414 ) Rename for consistency $custom-control-disabled-indicator-bg, $custom-control-disabled-description-color, $custom-control-checked-indicator-color, $custom-control-checked-indicator-bg, $custom-control-checked-indicator-box-shadow, $custom-control-focus-indicator-box-shadow, $custom-control-active-indicator-color, $custom-control-active-indicator-bg, $custom-control-active-indicator-box-shadow to $custom-control-indicator-disabled-bg, $custom-control-description-disabled-color, $custom-control-indicator-checked-color, $custom-control-indicator-checked-bg, $custom-control-indicator-checked-box-shadow, $custom-control-indicator-focus-box-shadow, $custom-control-indicator-active-color, $custom-control-indicator-active-bg, $custom-control-indicator-active-box-shadow, respectively
2017-06-13 08:45:36 -07:00
Patrick Yeo
3ecb8b661b
( #22414 ) Renamed for consistency $nav-disabled-link-color, $nav-tabs-active-link-color, $nav-tabs-active-link-bg, $nav-tabs-active-link-border-color, $nav-pills-active-link-color, $nav-pills-active-link-bg to $nav-link-disabled-color, $nav-tabs-link-active-color, $nav-tabs-link-active-bg, $nav-tabs-link-active-border-color, $nav-pills-link-active-color, $nav-pills-link-active-bg, respectively
2017-06-13 08:45:21 -07:00
Patrick Yeo
5e651615a3
( #22414 ) Renamed for consistency $modal-dialog-sm-up-margin-y, $modal-content-xs-box-shadow, $modal-content-sm-up-box-shadow, to $modal-dialog-margin-y-sm-up, $modal-content-box-shadow-xs, $modal-content-box-shadow-sm-up, respectively
2017-06-13 08:45:11 -07:00
Mark Otto
441f114681
Update _variables.scss
2017-06-13 08:44:55 -07:00
Mark Otto
c5d4430367
Mention variable naming scheme to help with #22414
2017-06-13 08:44:55 -07:00
Mark Otto
94ed0d901b
move to mixin so we can repeat it easier and allow folks to extend to custom states
2017-06-10 16:30:26 -07:00
Mark Otto
d6b0334a4e
remove icons for now
2017-06-06 22:45:37 -07:00
Mark Otto
58b7239c6c
add valid state
2017-06-06 21:53:23 -07:00
Mark Otto
6c214ad4c2
drop the old validation styles and docs
2017-06-06 11:27:29 -07:00
Mark Otto
d2c9f3f00a
flesh out invalid styles on .was-validated
2017-06-05 23:00:14 -07:00
Patrick Yeo
891bca435f
Fix overflowing text in Cards with word-wrap: break-word
2017-06-03 22:19:19 -07:00
Patrick Yeo
ec56bbe6bf
Rename $card-border-radius-inner to $card-inner-border-radius
2017-06-03 22:17:57 -07:00
Tom Van Rompaey
3a00b005c1
fix small typo inside _button-group.scss ( #22746 )
...
fron -> front
2017-06-03 09:53:50 +02:00
Mark Otto
4a554e5ff5
trying out new validation styles
2017-06-01 08:06:17 -07:00
Mark Otto
f13eb51940
Merge branch 'v4-dev' into form-tweaks
2017-05-31 21:29:23 -07:00
Mark Otto
332d882cdb
Merge branch 'v4-dev' into v4-docs-streamlined
2017-05-31 20:46:29 -07:00
Patrick Yeo
0800c7e1c8
Rename $card-link-hover-color to $card-inverse-link-hover-color
2017-05-31 20:34:01 -07:00
Mark Otto
f1a7f1f56a
Merge branch 'v4-docs-streamlined' of https://github.com/twbs/bootstrap into v4-docs-streamlined
2017-05-31 09:09:55 -07:00
Mark Otto
2fd192968d
Merge branch 'v4-dev' into v4-docs-streamlined
2017-05-30 23:31:40 -07:00
Mark Otto
960e73c16f
tweak dropdown caret size and placement
2017-05-30 13:59:24 -07:00
Mark Otto
48d17bc8b8
keep width, add comment
2017-05-28 21:12:55 -07:00
Mark Otto
8a2d845a4f
Fix responsive .col-{infix}-auto
...
Responsive automatic column resets weren't working because they inherited their `max-width` from lower grid tiers. This was because we were resetting the `width`, not the `max-width`.
2017-05-28 21:12:55 -07:00
Mark Otto
7c9efe786a
move .scss-lint.yml to route dir instead of symlink (which didn't work)
2017-05-27 17:54:23 -07:00
Mark Otto
04724939a3
Merge branch 'v4-dev' into form-tweaks
2017-05-26 21:22:08 -07:00
Patrick Yeo
f2829dd6ea
Rename $navbar-*-toggler-bg to $navbar-*-toggler-icon-bg since it's placed on .navbar-toggler-icon ( #22564 )
2017-05-26 20:55:07 -07:00
Mark Otto
7e1497ddb8
Revert simplified grid column styles from #22376
...
The premise for #22376 was that if we removed the `max-width` and `flex` properties, we could use the column classes as `width` utilities. The problem that I didn't remember at the time is that column classes have horizontal `padding` on them. This doesn't work for setting `width`. Perhaps more importantly, this causes #22649—the automatic sizing of columns is broken with the absence of `flex` styles.
/cc @sachinsinghi
2017-05-26 20:16:12 -07:00
Mark Otto
a11ae7facf
add a compact gutter option, .gutters-sm
2017-05-26 20:15:05 -07:00
Mark Otto
2a833d559a
Add box-shadow to .progress-bar ( #22579 )
...
* Add box-shadow to .progress-bar
Puts an unused variable back in use for when folks set `$enable-shadows` to `true`.
2017-05-25 21:32:59 -07:00
Johann-S
4c3b6c5ceb
Placement auto for popovers
2017-05-24 14:57:40 +02:00
Johann-S
2c72af88ee
Placement auto for tooltips
2017-05-24 14:57:40 +02:00
Johann-S
aa36439e17
Use Popper.js to manage arrow position
2017-05-23 15:19:54 +02:00
Catalin Zalog
3706c88348
Fix (css): force .navbar .dropdown-menu positioning
2017-05-22 16:20:58 +02:00
Johann-S
b36d8ae6cb
Use popper to align dropdown menu instead of using css with important
2017-05-17 22:03:11 +02:00
Johann-S
ba2352c14e
Force dropdown to be displayed in position static for navbar, to override Popper css
2017-05-16 14:48:12 +02:00
Johann-S
2b403819b7
Fix tooltip margin to be stick at their caller
2017-05-14 11:41:19 +02:00
Johann-S
dc35a840dc
Fix dropdown-menu-right and dropdown-menu-left for Dropdown
2017-05-14 11:41:19 +02:00
Johann-S
fc8b85b626
Fix some css for the arrow of Popover/Tooltip + update documentation
2017-05-14 11:41:19 +02:00
Johann-S
53ee455bc7
Handle dropup for Dropdown
2017-05-14 11:41:19 +02:00
Johann-S
69de65180f
Fix unit tests + Update Popper to 1.6.0
2017-05-14 11:41:19 +02:00
Johann-S
54a8ab4011
Begin to use Popper for Dropdown
2017-05-14 11:41:19 +02:00
Johann-S
d8996a7e0a
Fix arrow for tooltip and popover
2017-05-14 11:41:19 +02:00
Mark Otto
ee1af53d9f
Merge branch 'v4-dev' into form-tweaks
2017-05-07 17:44:57 -07:00
Sebastiaan Nijland
6c5346e300
Removed several unused scss variables ( #22539 )
2017-05-07 17:41:14 -07:00
Patrick H. Lauke
7338da0cdb
Add shim for "new" HTML5 structural elements ( #22573 )
...
For IE10 (and any older browsers) support , so at least the layout doesn't fall apart if author is using them.
2017-05-05 09:53:45 +01:00
Mark Otto
ca44f5b03a
Redo the small custom select vars
...
— Sizing shorthand comes last
— Add height var and put it to use
2017-04-22 11:56:27 -07:00
Mark Otto
dc3af6711d
Change how input and select height is computed
...
— Previously we weren't including the border-width on the computed height, leading to alignment issues.
— New system utilizes three variables (not ideal, but straightforward) for computing these heights. One for the vertical border, one for the line-height/font-size/padding dance, and one to add those together.
— Updates CSS across forms and custom forms to use new sizing. Special note here: form validation icon sizing uses the inner variables because background-image doesn't bleed into borders unless explicit background-clip.
2017-04-22 11:56:01 -07:00
Mark Otto
5463d8436b
Merge branch 'v4-dev' into form-tweaks
2017-04-21 23:36:24 -07:00
Mark Otto
7efe4ddee4
Match validation mixin focus state to normal focus state
2017-04-21 23:30:06 -07:00
Patrick Yeo
dd0ce3e4b2
Rename variable $input-border-focus to $input-border-color-focus ( #22413 )
...
* Rename variable $input-border-focus to $input-border-color-focus
* Rename variables $pagination-hover-border, $pagination-active-border, $pagination-disabled-border to $pagination-hover-border-color, $pagination-active-border-color, $pagination-disabled-border-color, respectively
* Rename variables $state-*-border to $state-*-border-color, respectively
* Rename variables $alert-*-border to $alert-*-border-color
* Rename $list-group-active-border to $list-group-active-border-color
* Rename $table-inverse-border to $table-inverse-border-color
* Rename $btn-*-border to $btn-*-border-color
* Rename $navbar-*-toggler-border to $navbar-*-toggler-border-color
2017-04-16 15:45:10 -07:00
Mark Otto
2075610491
Prevent long words in .card-titles from breaking auto layout
2017-04-16 14:02:12 -07:00
Patrick H. Lauke
6d64afe508
Replace dropdown backdrop hack with cleaner JS-only hack
...
* Replace backdrop with simple noop mouse listener
As discussed in https://github.com/twbs/bootstrap/pull/22422 the current
approach of injecting a backdrop (to work around iOS' broken event
delegation for the `click` event) has annoying consequences on
touch-enabled laptop/desktop devices.
Instead of a backdrop `<div>`, here we simply add extra empty/noop
mouse listeners to the immediate children of `<body>` (and remove
them when the dropdown is closed) in order to force iOS to properly
bubble a `click` resulting from a tap (essentially, method 2 from
https://www.quirksmode.org/blog/archives/2014/02/mouse_event_bub.html )
This is sufficient (except in rare cases where the user does manage to tap
on the body itself, rather than any child elements of body - which is not
very likely in an iOS phone/tablet scenario for most layouts) to get iOS to
get a grip and do the correct event bubbling/delegation, meaning the regular
"click" event will bubble back to the `<body>` when tapping outside of the dropdown,
and the dropdown will close properly (just like it already does, even without
this fix, in non-iOS touchscreen devices/browsers, like Chrome/Android and
Windows on a touch laptop).
This approach, though a bit hacky, has no impact on the DOM structure, and
has no unforeseen side effects on touch-enabled laptops/desktops. And crucially,
it works just fine in iOS.
* Remove dropdown backdrop styles
* Update doc for dropdowns and touch-enabled devices
2017-04-14 09:19:00 +01:00
Idan Cohen
8c97532719
Fix popover arrow color for bottom position
2017-04-13 10:52:41 +02:00