From 93592326c13b4adbc0d7ab7221f49141313abd95 Mon Sep 17 00:00:00 2001 From: yunti Date: Fri, 9 Oct 2015 15:45:07 +0100 Subject: [PATCH 01/21] Update deployment-on-heroku.rst --- docs/deployment-on-heroku.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/deployment-on-heroku.rst b/docs/deployment-on-heroku.rst index ef6dee59..d0d5abc9 100644 --- a/docs/deployment-on-heroku.rst +++ b/docs/deployment-on-heroku.rst @@ -29,6 +29,7 @@ You can either push the 'deploy' button in your generated README.rst or run thes heroku config:set DJANGO_MAILGUN_API_KEY=YOUR_MAILGUN_API_KEY heroku config:set PYTHONHASHSEED=random + heroku config:set DJANGO_ADMIN_URL=\^somelocation/ git push heroku master heroku run python manage.py migrate From ccc0262c5e44640d02ed7d32ad814a467bf6da30 Mon Sep 17 00:00:00 2001 From: MathijsHoogland Date: Wed, 14 Oct 2015 16:41:28 +0200 Subject: [PATCH 02/21] Added sudo: true to the travis file Sudo isn't true for default for some people in travis. --- {{cookiecutter.repo_name}}/.travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/{{cookiecutter.repo_name}}/.travis.yml b/{{cookiecutter.repo_name}}/.travis.yml index f7e40a1e..f5b02a01 100644 --- a/{{cookiecutter.repo_name}}/.travis.yml +++ b/{{cookiecutter.repo_name}}/.travis.yml @@ -1,3 +1,4 @@ +sudo: true before_install: - sudo apt-get update -qq - sudo apt-get install -qq build-essential gettext python-dev zlib1g-dev libpq-dev xvfb From f01cddeae691ff015879a1a658c677a8288560f0 Mon Sep 17 00:00:00 2001 From: Saurabh Kumar Date: Thu, 22 Oct 2015 00:19:24 +0530 Subject: [PATCH 03/21] fix requirement, update django-autoslug to 1.9.3 Thanks @cdvv7788 / @aniketmaithani --- {{cookiecutter.repo_name}}/requirements/base.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/{{cookiecutter.repo_name}}/requirements/base.txt b/{{cookiecutter.repo_name}}/requirements/base.txt index c94ee52d..1ebdac4b 100644 --- a/{{cookiecutter.repo_name}}/requirements/base.txt +++ b/{{cookiecutter.repo_name}}/requirements/base.txt @@ -34,7 +34,7 @@ psycopg2==2.6.1 # Unicode slugification unicode-slugify==0.1.3 -django-autoslug==1.9.2 +django-autoslug==1.9.3 # Time zones support pytz==2015.6 From 676739332adda9986ace626ef864deec2783d9ea Mon Sep 17 00:00:00 2001 From: Saurabh Kumar Date: Thu, 22 Oct 2015 00:24:18 +0530 Subject: [PATCH 04/21] Update requirement, coverage, factory-boy --- {{cookiecutter.repo_name}}/requirements/local.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/{{cookiecutter.repo_name}}/requirements/local.txt b/{{cookiecutter.repo_name}}/requirements/local.txt index 3906fc91..ea6663f8 100644 --- a/{{cookiecutter.repo_name}}/requirements/local.txt +++ b/{{cookiecutter.repo_name}}/requirements/local.txt @@ -1,11 +1,11 @@ # Local development dependencies go here -r base.txt -coverage==4.0 +coverage==4.0.1 Sphinx django-extensions==1.5.7 Werkzeug==0.10.4 django-test-plus==1.0.9 -factory_boy==2.5.2 +factory_boy==2.6.0 # django-debug-toolbar that works with Django 1.5+ django-debug-toolbar==1.4 From 2b550a75d5fec2b53747ab9fbb5cd56dd22dd358 Mon Sep 17 00:00:00 2001 From: Daniel Roy Greenfeld Date: Wed, 21 Oct 2015 13:19:08 -0700 Subject: [PATCH 05/21] removed isort link --- {{cookiecutter.repo_name}}/.editorconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/{{cookiecutter.repo_name}}/.editorconfig b/{{cookiecutter.repo_name}}/.editorconfig index e7aa555a..78c90f9c 100644 --- a/{{cookiecutter.repo_name}}/.editorconfig +++ b/{{cookiecutter.repo_name}}/.editorconfig @@ -13,7 +13,6 @@ indent_style = space indent_size = 4 [*.py] -# https://github.com/timothycrosley/isort/wiki/isort-Settings line_length=120 known_first_party={{ cookiecutter.repo_name }} multi_line_output=3 From 3d6169c2b9ec73db5eb1c1d52b5ff2ceb90a1d7b Mon Sep 17 00:00:00 2001 From: Audrey Roy Greenfeld Date: Thu, 22 Oct 2015 12:35:55 -0700 Subject: [PATCH 06/21] Use COPY instead of ADD as per https://docs.docker.com/articles/dockerfile_best-practices/#add-or-copy --- {{cookiecutter.repo_name}}/Dockerfile | 8 ++++---- {{cookiecutter.repo_name}}/Dockerfile-dev | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/{{cookiecutter.repo_name}}/Dockerfile b/{{cookiecutter.repo_name}}/Dockerfile index 2a038555..08d43f61 100644 --- a/{{cookiecutter.repo_name}}/Dockerfile +++ b/{{cookiecutter.repo_name}}/Dockerfile @@ -6,16 +6,16 @@ FROM python:2.7 ENV PYTHONUNBUFFERED 1 # Requirements have to be pulled and installed here, otherwise caching won't work -ADD ./requirements /requirements +COPY ./requirements /requirements RUN pip install -r /requirements/production.txt RUN groupadd -r django && useradd -r -g django django -ADD . /app +COPY . /app RUN chown -R django /app -ADD ./compose/django/gunicorn.sh /gunicorn.sh -ADD ./compose/django/entrypoint.sh /entrypoint.sh +COPY ./compose/django/gunicorn.sh /gunicorn.sh +COPY ./compose/django/entrypoint.sh /entrypoint.sh RUN chmod +x /entrypoint.sh && chown django /entrypoint.sh RUN chmod +x /gunicorn.sh && chown django /gunicorn.sh diff --git a/{{cookiecutter.repo_name}}/Dockerfile-dev b/{{cookiecutter.repo_name}}/Dockerfile-dev index f382b913..7f9985ba 100644 --- a/{{cookiecutter.repo_name}}/Dockerfile-dev +++ b/{{cookiecutter.repo_name}}/Dockerfile-dev @@ -6,16 +6,16 @@ FROM python:2.7 ENV PYTHONUNBUFFERED 1 # Requirements have to be pulled and installed here, otherwise caching won't work -ADD ./requirements /requirements +COPY ./requirements /requirements RUN pip install -r /requirements/local.txt RUN groupadd -r django && useradd -r -g django django -ADD . /app +COPY . /app RUN chown -R django /app -ADD ./compose/django/gunicorn.sh /gunicorn.sh -ADD ./compose/django/entrypoint.sh /entrypoint.sh +COPY ./compose/django/gunicorn.sh /gunicorn.sh +COPY ./compose/django/entrypoint.sh /entrypoint.sh RUN chmod +x /entrypoint.sh && chown django /entrypoint.sh RUN chmod +x /gunicorn.sh && chown django /gunicorn.sh From f9f4876e1154526cea7f2bb0b5fb9298d2a7ab67 Mon Sep 17 00:00:00 2001 From: Audrey Roy Greenfeld Date: Thu, 22 Oct 2015 12:37:14 -0700 Subject: [PATCH 07/21] Remove unnecessary gitkeep. Already another file in that dir. --- .../{{cookiecutter.repo_name}}/static/images/.gitkeep | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 {{cookiecutter.repo_name}}/{{cookiecutter.repo_name}}/static/images/.gitkeep diff --git a/{{cookiecutter.repo_name}}/{{cookiecutter.repo_name}}/static/images/.gitkeep b/{{cookiecutter.repo_name}}/{{cookiecutter.repo_name}}/static/images/.gitkeep deleted file mode 100644 index e69de29b..00000000 From e852bfe5b94b5d43366b7797d49a5eebf61e5294 Mon Sep 17 00:00:00 2001 From: Audrey Roy Greenfeld Date: Thu, 22 Oct 2015 12:42:53 -0700 Subject: [PATCH 08/21] Update history. Add TODOs for @pydanny and @theskumar to update for your changes :bell: --- CHANGELOG.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0b55e1f8..076a5e57 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,15 @@ All enhancements and patches to cookiecutter-django will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org/). +## [2015-10-22] +### Removed +- Remove unnecessary .gitkeep in static/images/ (@audreyr) + +## [2015-10-21] +### Changed +- TODO (@pydanny) +- TODO (@theskumar) + ## [2015-10-19] ### Changed - On Windows, don't install psycopg2 locally. Still install it in test/prod which are assumed to be Unix. (@audreyr) From 571530dd09653e401ae29d1b2d5e04a20bdd4b32 Mon Sep 17 00:00:00 2001 From: Jannis Gebauer Date: Sat, 24 Oct 2015 19:22:08 +0200 Subject: [PATCH 09/21] removed unused commands from development dockerfile --- {{cookiecutter.repo_name}}/Dockerfile-dev | 8 -------- 1 file changed, 8 deletions(-) diff --git a/{{cookiecutter.repo_name}}/Dockerfile-dev b/{{cookiecutter.repo_name}}/Dockerfile-dev index 7f9985ba..b2c87d2c 100644 --- a/{{cookiecutter.repo_name}}/Dockerfile-dev +++ b/{{cookiecutter.repo_name}}/Dockerfile-dev @@ -7,18 +7,10 @@ ENV PYTHONUNBUFFERED 1 # Requirements have to be pulled and installed here, otherwise caching won't work COPY ./requirements /requirements - RUN pip install -r /requirements/local.txt -RUN groupadd -r django && useradd -r -g django django -COPY . /app -RUN chown -R django /app - -COPY ./compose/django/gunicorn.sh /gunicorn.sh COPY ./compose/django/entrypoint.sh /entrypoint.sh - RUN chmod +x /entrypoint.sh && chown django /entrypoint.sh -RUN chmod +x /gunicorn.sh && chown django /gunicorn.sh WORKDIR /app From fe497c6dd0327110329099c80cf220faa3d8a9ec Mon Sep 17 00:00:00 2001 From: Jannis Gebauer Date: Sat, 24 Oct 2015 19:23:43 +0200 Subject: [PATCH 10/21] move development postgres data volume to /data/dev to avoid conflicts with production volume --- {{cookiecutter.repo_name}}/dev.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/{{cookiecutter.repo_name}}/dev.yml b/{{cookiecutter.repo_name}}/dev.yml index ffb40a0c..d50959d2 100644 --- a/{{cookiecutter.repo_name}}/dev.yml +++ b/{{cookiecutter.repo_name}}/dev.yml @@ -3,7 +3,7 @@ postgres: volumes: # If you are using boot2docker, postgres data has to live in the VM for now until #581 is fixed # for more info see here: https://github.com/boot2docker/boot2docker/issues/581 - - /data/{{cookiecutter.repo_name}}/postgres:/var/lib/postgresql/data + - /data/dev/{{cookiecutter.repo_name}}/postgres:/var/lib/postgresql/data django: dockerfile: Dockerfile-dev From fc54af7b158023011af5d54c43ec839e1c47d634 Mon Sep 17 00:00:00 2001 From: Jannis Gebauer Date: Sat, 24 Oct 2015 19:25:46 +0200 Subject: [PATCH 11/21] use REDIS_URL instead of DJANGO_CACHE_URL, fixes #379 --- {{cookiecutter.repo_name}}/compose/django/entrypoint.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/{{cookiecutter.repo_name}}/compose/django/entrypoint.sh b/{{cookiecutter.repo_name}}/compose/django/entrypoint.sh index 8c07a641..ffae9009 100644 --- a/{{cookiecutter.repo_name}}/compose/django/entrypoint.sh +++ b/{{cookiecutter.repo_name}}/compose/django/entrypoint.sh @@ -4,7 +4,7 @@ set -e # Since docker-compose relies heavily on environment variables itself for configuration, we'd have to define multiple # environment variables just to support cookiecutter out of the box. That makes no sense, so this little entrypoint # does all this for us. -export DJANGO_CACHE_URL=redis://redis:6379/0 +export REDIS_URL=redis://redis:6379/0 # the official postgres image uses 'postgres' as default user if not set explictly. if [ -z "$POSTGRES_ENV_POSTGRES_USER" ]; then @@ -13,6 +13,6 @@ fi export DATABASE_URL=postgres://$POSTGRES_ENV_POSTGRES_USER:$POSTGRES_ENV_POSTGRES_PASSWORD@postgres:5432/$POSTGRES_ENV_POSTGRES_USER {% if cookiecutter.use_celery == 'y' %} -export CELERY_BROKER_URL=$DJANGO_CACHE_URL +export CELERY_BROKER_URL=$REDIS_URL {% endif %} exec "$@" \ No newline at end of file From 8fe03fe5531c0981d9b7b5a8c931f91590c0cd84 Mon Sep 17 00:00:00 2001 From: Jannis Gebauer Date: Sat, 24 Oct 2015 19:27:04 +0200 Subject: [PATCH 12/21] no need to chown the file --- {{cookiecutter.repo_name}}/Dockerfile-dev | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/{{cookiecutter.repo_name}}/Dockerfile-dev b/{{cookiecutter.repo_name}}/Dockerfile-dev index b2c87d2c..f07fe36a 100644 --- a/{{cookiecutter.repo_name}}/Dockerfile-dev +++ b/{{cookiecutter.repo_name}}/Dockerfile-dev @@ -10,7 +10,7 @@ COPY ./requirements /requirements RUN pip install -r /requirements/local.txt COPY ./compose/django/entrypoint.sh /entrypoint.sh -RUN chmod +x /entrypoint.sh && chown django /entrypoint.sh +RUN chmod +x /entrypoint.sh WORKDIR /app From 683872bc207cec7377cbff4043d0b5832c3b3385 Mon Sep 17 00:00:00 2001 From: Jannis Gebauer Date: Sat, 24 Oct 2015 19:38:06 +0200 Subject: [PATCH 13/21] added the docker related changes from @audreyr and @jayfk --- CHANGELOG.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 076a5e57..194d0177 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,13 @@ All enhancements and patches to cookiecutter-django will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org/). +## [2015-10-24] +### Changed +- Replaced ADD with COPY in dockerfiles (@audreyr) +- Simplified development dockerfile (@jayfk) +- Moved the docker postgres volume on the development environment to it's own subfolder (@jayfk) +- Renamed DJANGO_CACHE_URL to REDIS_URL (@jayfk / proposed by @pydanny) + ## [2015-10-22] ### Removed - Remove unnecessary .gitkeep in static/images/ (@audreyr) From d04a59fbe87aadc6ee9f84c0774e7b1e87e18716 Mon Sep 17 00:00:00 2001 From: Audrey Roy Greenfeld Date: Sat, 24 Oct 2015 20:31:36 -0500 Subject: [PATCH 14/21] Update nav in base template to latest Bootstrap 4 version. --- CHANGELOG.md | 1 + .../templates/base.html | 38 ++++++++++++------- 2 files changed, 26 insertions(+), 13 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 194d0177..79806011 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). ## [2015-10-24] ### Changed +- Update nav in base template to latest Bootstrap 4 version (@audreyr) - Replaced ADD with COPY in dockerfiles (@audreyr) - Simplified development dockerfile (@jayfk) - Moved the docker postgres volume on the development environment to it's own subfolder (@jayfk) diff --git a/{{cookiecutter.repo_name}}/{{cookiecutter.repo_name}}/templates/base.html b/{{cookiecutter.repo_name}}/{{cookiecutter.repo_name}}/templates/base.html index 0931ca8f..a30c03c0 100644 --- a/{{cookiecutter.repo_name}}/{{cookiecutter.repo_name}}/templates/base.html +++ b/{{cookiecutter.repo_name}}/{{cookiecutter.repo_name}}/templates/base.html @@ -30,31 +30,43 @@ - +
From 0351c29295a5a6175a3da8242337126834ac4051 Mon Sep 17 00:00:00 2001 From: Daniel Roy Greenfeld Date: Sun, 25 Oct 2015 08:36:20 -0700 Subject: [PATCH 15/21] Added so we can list it on PyPI and therefore displayed on djangopackages.com as compatible with Python 3. --- CHANGELOG.md | 8 ++++++-- setup.py | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 60 insertions(+), 2 deletions(-) create mode 100644 setup.py diff --git a/CHANGELOG.md b/CHANGELOG.md index 79806011..79c19d62 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,9 @@ All enhancements and patches to cookiecutter-django will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org/). +## [2015-10-25] +- Added `setup.py` so we can list it on PyPI and therefore displayed on djangopackages.com as compatible with Python 3. + ## [2015-10-24] ### Changed - Update nav in base template to latest Bootstrap 4 version (@audreyr) @@ -16,8 +19,9 @@ This project adheres to [Semantic Versioning](http://semver.org/). ## [2015-10-21] ### Changed -- TODO (@pydanny) -- TODO (@theskumar) +- Updated requirements (@theskumar) +### Removed +- editorconfig comment that was just a isort settings link (@pydanny) ## [2015-10-19] ### Changed diff --git a/setup.py b/setup.py new file mode 100644 index 00000000..2e2652aa --- /dev/null +++ b/setup.py @@ -0,0 +1,54 @@ +#!/usr/bin/env python + +import os +import platform +import sys + +try: + from setuptools import setup +except ImportError: + from distutils.core import setup + +version = "1.0" + +if sys.argv[-1] == 'tag': + os.system("git tag -a %s -m 'version %s'" % (version, version)) + os.system("git push --tags") + sys.exit() + +with open('README.rst') as readme_file: + long_description = readme_file.read() + +setup( + name='cookiecutter-django', + version=version, + description='A Cookiecutter template for creating production-ready Django projects quickly.', + long_description=long_description, + author='Daniel Roy Greenfeld', + author_email='pydanny@gmail.com', + url='https://github.com/pydanny/cookiecutter-django', + packages=[], + license='BSD', + zip_safe=False, + classifiers=[ + 'Development Status :: 5 - Production/Stable', + 'Environment :: Console', + 'Framework :: Django :: 1.8', + 'Intended Audience :: Developers', + 'Natural Language :: English', + 'License :: OSI Approved :: BSD License', + 'Programming Language :: Python', + 'Programming Language :: Python :: 2', + 'Programming Language :: Python :: 2.7', + 'Programming Language :: Python :: 3', + 'Programming Language :: Python :: 3.4', + 'Programming Language :: Python :: 3.5', + 'Programming Language :: Python :: Implementation :: CPython', + 'Programming Language :: Python :: Implementation :: PyPy', + 'Topic :: Software Development', + ], + keywords=( + 'cookiecutter, Python, projects, project templates, django, ' + 'skeleton, scaffolding, project directory, setup.py' + ), +) From b76f402541a4d1eb7e2582dd804f3b4f4946b86f Mon Sep 17 00:00:00 2001 From: Daniel Roy Greenfeld Date: Sun, 25 Oct 2015 09:29:43 -0700 Subject: [PATCH 16/21] Added version and tagging policy --- CHANGELOG.md | 4 +++- setup.py | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 79c19d62..e3fb8232 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,9 @@ All enhancements and patches to cookiecutter-django will be documented in this f This project adheres to [Semantic Versioning](http://semver.org/). ## [2015-10-25] -- Added `setup.py` so we can list it on PyPI and therefore displayed on djangopackages.com as compatible with Python 3. +### Added +- `setup.py` so we can list it on PyPI and therefore displayed on djangopackages.com as compatible with Python 3. (@pydanny) +- Versioning and tagging policy (@pydanny) ## [2015-10-24] ### Changed diff --git a/setup.py b/setup.py index 2e2652aa..2d7bfee2 100644 --- a/setup.py +++ b/setup.py @@ -9,7 +9,9 @@ try: except ImportError: from distutils.core import setup -version = "1.0" +# Our version ALWAYS matches the version of Django we support +# If Django has a new release, we branch, tag, then update this setting after the tag. +version = "1.8.5" if sys.argv[-1] == 'tag': os.system("git tag -a %s -m 'version %s'" % (version, version)) From 0c80d91112bd9910b6b214cafde9a8cc9b64a325 Mon Sep 17 00:00:00 2001 From: Daniel Roy Greenfeld Date: Sun, 25 Oct 2015 09:30:19 -0700 Subject: [PATCH 17/21] Version --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 2d7bfee2..31edec6c 100644 --- a/setup.py +++ b/setup.py @@ -33,7 +33,7 @@ setup( license='BSD', zip_safe=False, classifiers=[ - 'Development Status :: 5 - Production/Stable', + 'Development Status :: 4 - Beta', 'Environment :: Console', 'Framework :: Django :: 1.8', 'Intended Audience :: Developers', From 8307e43d15b5f20d9f0d7e5f88a30a97ed73b67c Mon Sep 17 00:00:00 2001 From: Audrey Roy Greenfeld Date: Sun, 25 Oct 2015 17:30:36 -0500 Subject: [PATCH 18/21] Move LOGGING setting to production from common, since it's not useful locally. --- CHANGELOG.md | 1 + .../config/settings/common.py | 48 ------------------- .../config/settings/production.py | 48 +++++++++++++++++++ 3 files changed, 49 insertions(+), 48 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e3fb8232..66e36ee7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). ## [2015-10-25] ### Added +- Move current logging config into production.py since it's not useful locally anyway. Used only if not using Sentry. (@audreyr) - `setup.py` so we can list it on PyPI and therefore displayed on djangopackages.com as compatible with Python 3. (@pydanny) - Versioning and tagging policy (@pydanny) diff --git a/{{cookiecutter.repo_name}}/config/settings/common.py b/{{cookiecutter.repo_name}}/config/settings/common.py index 836f099e..a0389349 100644 --- a/{{cookiecutter.repo_name}}/config/settings/common.py +++ b/{{cookiecutter.repo_name}}/config/settings/common.py @@ -221,54 +221,6 @@ LOGIN_URL = 'account_login' # SLUGLIFIER AUTOSLUG_SLUGIFY_FUNCTION = 'slugify.slugify' - -# LOGGING CONFIGURATION -# ------------------------------------------------------------------------------ -# See: https://docs.djangoproject.com/en/dev/ref/settings/#logging -# A sample logging configuration. The only tangible logging -# performed by this configuration is to send an email to -# the site admins on every HTTP 500 error when DEBUG=False. -# See http://docs.djangoproject.com/en/dev/topics/logging for -# more details on how to customize your logging configuration. -LOGGING = { - 'version': 1, - 'disable_existing_loggers': False, - 'filters': { - 'require_debug_false': { - '()': 'django.utils.log.RequireDebugFalse' - } - }, - 'formatters': { - 'verbose': { - 'format': '%(levelname)s %(asctime)s %(module)s ' - '%(process)d %(thread)d %(message)s' - }, - }, - 'handlers': { - 'mail_admins': { - 'level': 'ERROR', - 'filters': ['require_debug_false'], - 'class': 'django.utils.log.AdminEmailHandler' - }, - 'console': { - 'level': 'DEBUG', - 'class': 'logging.StreamHandler', - 'formatter': 'verbose', - }, - }, - 'loggers': { - 'django.request': { - 'handlers': ['mail_admins'], - 'level': 'ERROR', - 'propagate': True - }, - 'django.security.DisallowedHost': { - 'level': 'ERROR', - 'handlers': ['console', 'mail_admins'], - 'propagate': True - } - } -} {% if cookiecutter.use_celery == "y" %} ########## CELERY INSTALLED_APPS += ('{{cookiecutter.repo_name}}.taskapp.celery.CeleryConfig',) diff --git a/{{cookiecutter.repo_name}}/config/settings/production.py b/{{cookiecutter.repo_name}}/config/settings/production.py index e21bc59b..2a14ae9d 100644 --- a/{{cookiecutter.repo_name}}/config/settings/production.py +++ b/{{cookiecutter.repo_name}}/config/settings/production.py @@ -216,6 +216,54 @@ RAVEN_CONFIG = { 'CELERY_LOGLEVEL': env.int('DJANGO_SENTRY_LOG_LEVEL', logging.INFO), 'DSN': SENTRY_DSN } +{% elif cookiecutter.use_sentry == "n" %} +# LOGGING CONFIGURATION +# ------------------------------------------------------------------------------ +# See: https://docs.djangoproject.com/en/dev/ref/settings/#logging +# A sample logging configuration. The only tangible logging +# performed by this configuration is to send an email to +# the site admins on every HTTP 500 error when DEBUG=False. +# See http://docs.djangoproject.com/en/dev/topics/logging for +# more details on how to customize your logging configuration. +LOGGING = { + 'version': 1, + 'disable_existing_loggers': False, + 'filters': { + 'require_debug_false': { + '()': 'django.utils.log.RequireDebugFalse' + } + }, + 'formatters': { + 'verbose': { + 'format': '%(levelname)s %(asctime)s %(module)s ' + '%(process)d %(thread)d %(message)s' + }, + }, + 'handlers': { + 'mail_admins': { + 'level': 'ERROR', + 'filters': ['require_debug_false'], + 'class': 'django.utils.log.AdminEmailHandler' + }, + 'console': { + 'level': 'DEBUG', + 'class': 'logging.StreamHandler', + 'formatter': 'verbose', + }, + }, + 'loggers': { + 'django.request': { + 'handlers': ['mail_admins'], + 'level': 'ERROR', + 'propagate': True + }, + 'django.security.DisallowedHost': { + 'level': 'ERROR', + 'handlers': ['console', 'mail_admins'], + 'propagate': True + } + } +} {% endif %} # Custom Admin URL, use {% raw %}{% url 'admin:index' %}{% endraw %} ADMIN_URL = env('DJANGO_ADMIN_URL') From 084fb2529e28d60f328efaa1e107389409f72699 Mon Sep 17 00:00:00 2001 From: Daniel Roy Greenfeld Date: Sun, 25 Oct 2015 17:37:34 -0700 Subject: [PATCH 19/21] Fixed flake8 issue --- CHANGELOG.md | 1 + {{cookiecutter.repo_name}}/config/settings/common.py | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 66e36ee7..05ca170e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). - Move current logging config into production.py since it's not useful locally anyway. Used only if not using Sentry. (@audreyr) - `setup.py` so we can list it on PyPI and therefore displayed on djangopackages.com as compatible with Python 3. (@pydanny) - Versioning and tagging policy (@pydanny) +- Fixed flake8 issue (@pydanny) ## [2015-10-24] ### Changed diff --git a/{{cookiecutter.repo_name}}/config/settings/common.py b/{{cookiecutter.repo_name}}/config/settings/common.py index a0389349..a0ab6063 100644 --- a/{{cookiecutter.repo_name}}/config/settings/common.py +++ b/{{cookiecutter.repo_name}}/config/settings/common.py @@ -220,7 +220,6 @@ LOGIN_URL = 'account_login' # SLUGLIFIER AUTOSLUG_SLUGIFY_FUNCTION = 'slugify.slugify' - {% if cookiecutter.use_celery == "y" %} ########## CELERY INSTALLED_APPS += ('{{cookiecutter.repo_name}}.taskapp.celery.CeleryConfig',) From 7a304981cd1ae3790cf31fcc9ef23c2e392a8117 Mon Sep 17 00:00:00 2001 From: Audrey Roy Greenfeld Date: Tue, 27 Oct 2015 23:01:10 -0500 Subject: [PATCH 20/21] Add #378 to changelog. --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 05ca170e..baa80010 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ All enhancements and patches to cookiecutter-django will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org/). +## [2015-10-27] +### Added +- Added sudo: true to the travis file (@MathijsHoogland) + ## [2015-10-25] ### Added - Move current logging config into production.py since it's not useful locally anyway. Used only if not using Sentry. (@audreyr) From aedba0b1f5894464aa5c67ed710eac88dc1e1107 Mon Sep 17 00:00:00 2001 From: Audrey Roy Greenfeld Date: Thu, 29 Oct 2015 20:05:41 -0500 Subject: [PATCH 21/21] Add #371 to changelog. --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index baa80010..b5348300 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ All enhancements and patches to cookiecutter-django will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org/). +## [2015-10-28] +### Changed +- Update deployment-on-heroku.rst for ADMIN_URL (@yunti) + ## [2015-10-27] ### Added - Added sudo: true to the travis file (@MathijsHoogland)