Allow conn_max_age to accept None for flexibility in configuration

This commit is contained in:
Matt Seymour 2025-07-11 17:15:05 +01:00
parent 34170b5aef
commit 0819957676
2 changed files with 5 additions and 5 deletions

View file

@ -127,7 +127,7 @@ def config(
env: str = DEFAULT_ENV, env: str = DEFAULT_ENV,
default: Optional[str] = None, default: Optional[str] = None,
engine: Optional[str] = None, engine: Optional[str] = None,
conn_max_age: int = 0, conn_max_age: Optional[int] = 0,
conn_health_checks: bool = False, conn_health_checks: bool = False,
disable_server_side_cursors: bool = False, disable_server_side_cursors: bool = False,
ssl_require: bool = False, ssl_require: bool = False,
@ -158,7 +158,7 @@ def config(
def parse( def parse(
url: str, url: str,
engine: Optional[str] = None, engine: Optional[str] = None,
conn_max_age: int = 0, conn_max_age: Optional[int] = 0,
conn_health_checks: bool = False, conn_health_checks: bool = False,
disable_server_side_cursors: bool = False, disable_server_side_cursors: bool = False,
ssl_require: bool = False, ssl_require: bool = False,
@ -231,7 +231,7 @@ def _parse_value(value: str) -> OptionType:
def _convert_to_settings( def _convert_to_settings(
engine: Optional[str], engine: Optional[str],
conn_max_age: int, conn_max_age: Optional[int],
conn_health_checks: bool, conn_health_checks: bool,
disable_server_side_cursors: bool, disable_server_side_cursors: bool,
ssl_require: bool, ssl_require: bool,

View file

@ -266,8 +266,8 @@ class DatabaseTestSuite(unittest.TestCase):
assert url["CONN_MAX_AGE"] == conn_max_age assert url["CONN_MAX_AGE"] == conn_max_age
def test_config_conn_max_age_setting(self) -> None: def test_config_conn_max_age_setting_none(self) -> None:
conn_max_age = 600 conn_max_age = None
with mock.patch.dict( with mock.patch.dict(
os.environ, os.environ,
{ {