Hopiu/djLint
1
0
Fork 0
mirror of https://github.com/Hopiu/djLint.git synced 2026-04-29 01:14:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(linter): fixes false positive on D018

Browse source 
closes #501
This commit is contained in:
Christopher Pickering 2023-01-04 09:03:24 -06:00
parent d43513a8e5
commit ebd099f011
No known key found for this signature in database
GPG key ID: E14DB3B0A0FACF84
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/djlint/rules.yaml
View file

@ -136,7 +136,7 @@
flags: re.DOTALL|re.I flags: re.DOTALL|re.I
patterns: patterns:
- <(?:a|div|span|input)\b[^>]*?\s(?:href|data-url|data-src|action)=[\"|'](?!(?:https?://)|javascript:|on\w+:|mailto:|tel:|data:)[\w|/]+ - <(?:a|div|span|input)\b[^>]*?\s(?:href|data-url|data-src|action)=[\"|'](?!(?:https?://)|javascript:|on\w+:|mailto:|tel:|data:)[\w|/]+
- <form\s+?[^>]*?(?:action)=[\"|'](?!(?:https?://)|javascript:|on\w+:|mailto:|tel:)[\w|/]+ - <form\b[^>]*?(?:\saction)=[\"|'](?!(?:https?://)|javascript:|on\w+:|mailto:|tel:)[\w|/]+
- rule: - rule:
name: J018 name: J018
message: (Jinja) Internal links should use the {{ url_for() ... }} pattern. message: (Jinja) Internal links should use the {{ url_for() ... }} pattern.

9
tests/test_linter/test_linter.py
View file

@ -451,6 +451,15 @@ def test_DJ018(runner: CliRunner, tmp_file: TextIO) -> None:
result = runner.invoke(djlint, [tmp_file.name, "--profile", "jinja"]) result = runner.invoke(djlint, [tmp_file.name, "--profile", "jinja"])
assert result.exit_code == 0 assert result.exit_code == 0
# test data-actions
write_to_file(
tmp_file.name,
b"""<form action="{% url 'something' %}" data-action="xxx"></form>""",
)
result = runner.invoke(djlint, [tmp_file.name, "--profile", "django"])
assert "D018" not in result.output
def test_H019(runner: CliRunner, tmp_file: TextIO) -> None: def test_H019(runner: CliRunner, tmp_file: TextIO) -> None:
write_to_file(tmp_file.name, b"<a href='javascript:abc()'>asdf</a>") write_to_file(tmp_file.name, b"<a href='javascript:abc()'>asdf</a>")