From b55f5e7801ceb155d0d998ebc0672cc6a4320570 Mon Sep 17 00:00:00 2001 From: ibaguio Date: Wed, 15 Mar 2023 11:51:26 +0800 Subject: [PATCH 1/2] Fix bug when order value is zero Bug: when order value is zero, a new order value is generated --- adminsortable/models.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/adminsortable/models.py b/adminsortable/models.py index 94e15f7..bb35bf9 100644 --- a/adminsortable/models.py +++ b/adminsortable/models.py @@ -89,7 +89,8 @@ class SortableMixin(models.Model): def save(self, *args, **kwargs): needs_default = (self._state.adding if VERSION >= (1, 8) else not self.pk) - if not getattr(self, self.order_field_name) and needs_default: + order_value = getattr(self, self.order_field_name) + if order_value is None and needs_default: try: current_max = self.__class__.objects.aggregate( models.Max(self.order_field_name))[self.order_field_name + '__max'] or 0 From 52c05cbf937252add280a2e601c65986683405ad Mon Sep 17 00:00:00 2001 From: ibaguio Date: Wed, 15 Mar 2023 12:26:00 +0800 Subject: [PATCH 2/2] Bump version 2.3.1 --- adminsortable/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adminsortable/__init__.py b/adminsortable/__init__.py index fbbe635..40b4bc4 100644 --- a/adminsortable/__init__.py +++ b/adminsortable/__init__.py @@ -1,4 +1,4 @@ -VERSION = (2, 3, 0) +VERSION = (2, 3, 1) DEV_N = None