Hopiu/django-admin-sortable
1
0
Fork 0
mirror of https://github.com/jazzband/django-admin-sortable.git synced 2026-05-28 16:28:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Avoid unnecessary db queries: perform the update iff the order field has changed.

Browse source
This commit is contained in:
Anton Shevchenko 2017-03-08 23:28:40 -05:00
parent f2f5daf831
commit eb5a9e0a8a
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
adminsortable/admin.py
View file

@ -297,9 +297,11 @@ class SortableAdmin(SortableAdminBase, ModelAdmin):
for index in indexes: for index in indexes:
obj = objects_dict.get(index) obj = objects_dict.get(index)
setattr(obj, order_field_name, start_index) # perform the update iff the order field has changed
# only update the object's order field if getattr(obj, order_field_name) != start_index:
obj.save(update_fields=(order_field_name,)) setattr(obj, order_field_name, start_index)
# only update the object's order field
obj.save(update_fields=(order_field_name,))
start_index += step start_index += step
response = {'objects_sorted': True} response = {'objects_sorted': True}
except (KeyError, IndexError, klass.DoesNotExist, except (KeyError, IndexError, klass.DoesNotExist,