Hopiu/django-admin2
1
0
Fork 0
mirror of https://github.com/jazzband/django-admin2.git synced 2026-04-06 16:01:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Making permissions easier to manage

Browse source
This commit is contained in:
Daniel Greenfeld 2013-06-04 19:03:40 +02:00
parent 39a4d01706
commit 9d6cbe3094
1 changed files with 27 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
djadmin2/actions.py
View file

@ -32,9 +32,6 @@ class BaseListAction(object):
self.queryset = queryset self.queryset = queryset
self.model = queryset.model self.model = queryset.model
self.options = utils.model_options(self.model) self.options = utils.model_options(self.model)
self.permission_name = '%s.delete.%s' \
% (self.options.app_label, self.options.object_name.lower())
self.has_permission = request.user.has_perm(self.permission_name)
self.item_count = len(queryset) self.item_count = len(queryset)
@ -44,6 +41,10 @@ class BaseListAction(object):
objects_name = self.options.verbose_name_plural objects_name = self.options.verbose_name_plural
self.objects_name = unicode(objects_name) self.objects_name = unicode(objects_name)
@property
def permission_name(self):
return NotImplemented
def description(self): def description(self):
return NotImplemented return NotImplemented
@ -54,6 +55,11 @@ class BaseListAction(object):
return NotImplemented return NotImplemented
def __call__(self): def __call__(self):
if not self.request.user.has_perm(self.permission_name):
message = _("Permission to '%s' denied" % force_text(self.description))
messages.add_message(self.request, messages.INFO, message)
return None
if self.item_count > 0: if self.item_count > 0:
return self.get_response() return self.get_response()
else: else:
@ -72,35 +78,27 @@ class DeleteSelectedAction(BaseListAction):
def get_response(self): def get_response(self):
if self.request.POST.get('confirmed'): if self.request.POST.get('confirmed'):
# The user has confirmed that they want to delete the objects. # The user has confirmed that they want to delete the objects.
if self.has_permission: num_objects_deleted = len(self.queryset)
num_objects_deleted = len(self.queryset) self.queryset.delete()
self.queryset.delete() message = _("Successfully deleted %d %s" % \
message = _("Successfully deleted %d %s" % \ (num_objects_deleted, self.objects_name))
(num_objects_deleted, self.objects_name)) messages.add_message(self.request, messages.INFO, message)
messages.add_message(self.request, messages.INFO, message) return None
return None
else:
raise PermissionDenied
else: else:
# The user has not confirmed that they want to delete the objects, so # The user has not confirmed that they want to delete the objects, so
# render a template asking for their confirmation. # render a template asking for their confirmation.
if self.has_permission:
def _format_callback(obj): def _format_callback(obj):
opts = utils.model_options(obj) opts = utils.model_options(obj)
return '%s: %s' % (force_text(capfirst(opts.verbose_name)), return '%s: %s' % (force_text(capfirst(opts.verbose_name)),
force_text(obj)) force_text(obj))
collector = utils.NestedObjects(using=None) collector = utils.NestedObjects(using=None)
collector.collect(self.queryset) collector.collect(self.queryset)
context = { context = {
'queryset': self.queryset, 'queryset': self.queryset,
'objects_name': self.objects_name, 'objects_name': self.objects_name,
'deletable_objects': collector.nested(_format_callback), 'deletable_objects': collector.nested(_format_callback),
} }
return TemplateResponse(self.request, self.template, context) return TemplateResponse(self.request, self.template, context)
else:
message = _("Permission to delete %s denied" % self.objects_name)
messages.add_message(self.request, messages.INFO, message)
return None