From 7b3c107758411ef6416c19b85c5e240b07dabe2c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matth=C3=A4us=20G=2E=20Chajdas?= <dev@anteru.net>
Date: Sun, 6 May 2018 09:29:15 +0200
Subject: [PATCH] Add PIWIK_DISABLE_COOKIES.

This option disables cookies -- it's off by default.
---
 analytical/templatetags/piwik.py   | 10 +++++++++-
 analytical/tests/test_tag_piwik.py |  5 +++++
 docs/services/piwik.rst            |  7 +++++++
 3 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/analytical/templatetags/piwik.py b/analytical/templatetags/piwik.py
index ce8fb9b..4a3a6f9 100644
--- a/analytical/templatetags/piwik.py
+++ b/analytical/templatetags/piwik.py
@@ -8,6 +8,7 @@ from collections import namedtuple
 from itertools import chain
 import re
 
+from django.conf import settings
 from django.template import Library, Node, TemplateSyntaxError
 
 from analytical.utils import (is_internal_ip, disable_html,
@@ -24,6 +25,7 @@ TRACKING_CODE = """
 <script type="text/javascript">
   var _paq = _paq || [];
   %(variables)s
+  %(commands)s
   _paq.push(['trackPageView']);
   _paq.push(['enableLinkTracking']);
   (function() {
@@ -39,6 +41,7 @@ TRACKING_CODE = """
 
 VARIABLE_CODE = '_paq.push(["setCustomVariable", %(index)s, "%(name)s", "%(value)s", "%(scope)s"]);'  # noqa
 IDENTITY_CODE = '_paq.push(["setUserId", "%(userid)s"]);'
+DISABLE_COOKIES_CODE = '_paq.push([\'disableCookies\']);'
 
 DEFAULT_SCOPE = 'page'
 
@@ -89,6 +92,10 @@ class PiwikNode(Node):
         variables_code = (VARIABLE_CODE % PiwikVar(*var)._asdict()
                           for var in complete_variables)
 
+        commands = []
+        if getattr(settings, 'PIWIK_DISABLE_COOKIES', False):
+            commands.append(DISABLE_COOKIES_CODE)
+
         userid = get_identity(context, 'piwik')
         if userid is not None:
             variables_code = chain(variables_code, (
@@ -98,7 +105,8 @@ class PiwikNode(Node):
         html = TRACKING_CODE % {
             'url': self.domain_path,
             'siteid': self.site_id,
-            'variables': '\n  '.join(variables_code)
+            'variables': '\n  '.join(variables_code),
+            'commands' : '\n  '.join(commands)
         }
         if is_internal_ip(context, 'PIWIK'):
             html = disable_html(html, 'Piwik')
diff --git a/analytical/tests/test_tag_piwik.py b/analytical/tests/test_tag_piwik.py
index f2b191f..6ba2d85 100644
--- a/analytical/tests/test_tag_piwik.py
+++ b/analytical/tests/test_tag_piwik.py
@@ -145,3 +145,8 @@ class PiwikTagTestCase(TagTestCase):
         msg = 'Incorrect Piwik user tracking rendering.\nFound:\n%s\nIn:\n%s'
         var_code = '_paq.push(["setUserId", "BDFL"]);'
         self.assertNotIn(var_code, r, msg % (var_code, r))
+
+    @override_settings(PIWIK_DISABLE_COOKIES=True)
+    def test_disable_coolies(self):
+        r = PiwikNode().render(Context({}))
+        self.assertTrue("_paq.push(['disableCookies']);" in r, r)
diff --git a/docs/services/piwik.rst b/docs/services/piwik.rst
index 1bc4cb6..0fa5571 100644
--- a/docs/services/piwik.rst
+++ b/docs/services/piwik.rst
@@ -142,6 +142,13 @@ set the context variable ``analytical_identity`` (for global configuration) or
 
 .. _`track individual users`: http://developer.piwik.org/guides/tracking-javascript-guide#user-id
 
+Disabling cookies
+-----------------
+
+If you want to `disable cookies`_, set :data:`PIWIKI_DISABLE_COOKIES` to
+:const:`True`. This is disabled by default.
+
+.. _`disable cookies`: https://matomo.org/faq/general/faq_157/
 
 Internal IP addresses
 ---------------------