Hopiu/django-auditlog
1
0
Fork 0
mirror of https://github.com/jazzband/django-auditlog.git synced 2026-03-16 22:20:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix LogEntry.changes_dict() to return {} when json.loads() returns None (#472)

Browse source 
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
This commit is contained in:
Thomas Steen Rasmussen 2022-12-13 21:35:31 +01:00 committed by GitHub
parent cd1ba3d01b
commit 27f57a53ff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
CHANGELOG.md
View file

@ -2,6 +2,10 @@
## Next Release
#### Fixes
- fix: Make sure `LogEntry.changes_dict()` returns an empty dict instead of `None` when `json.loads()` returns `None`. ([#472](https://github.com/jazzband/django-auditlog/pull/472))
## 2.2.1 (2022-11-28)
#### Fixes

2
auditlog/models.py
View file

@ -387,7 +387,7 @@ class LogEntry(models.Model):
:return: The changes recorded in this log entry as a dictionary object.
"""
try:
return json.loads(self.changes)
return json.loads(self.changes) or {}
except ValueError:
return {}

1
auditlog_tests/tests.py
View file

@ -1841,6 +1841,7 @@ class TestAccessLog(TestCase):
log_entry.action, LogEntry.Action.ACCESS, msg="Action is 'ACCESS'"
)
self.assertEqual(log_entry.changes, "null")
self.assertEqual(log_entry.changes_dict, {})
@override_settings(AUDITLOG_DISABLE_ON_RAW_SAVE=True)