Hopiu/django-auditlog
1
0
Fork 0
mirror of https://github.com/jazzband/django-auditlog.git synced 2026-03-16 22:20:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Only save a log entry when something changed.

Browse source
This commit is contained in:
Jan-Jelle Kester 2013-10-21 22:27:35 +02:00
parent aa94bf4496
commit 74c962a2a0
2 changed files with 23 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
src/auditlog/models.py
View file

@ -15,27 +15,31 @@ class LogEntryManager(models.Manager):
Helper method to create a new log entry. This method automatically fills in some data when it is left out. It
was created to keep things DRY.
"""
if not 'content_type' in kwargs:
kwargs['content_type'] = ContentType.objects.get_for_model(instance)
if not 'object_pk' in kwargs:
kwargs['object_pk'] = instance.pk
if not 'object_repr' in kwargs:
kwargs['object_repr'] = str(instance)
if not 'object_id' in kwargs:
pk_field = instance._meta.pk.name
pk = getattr(instance, pk_field, None)
if isinstance(pk, int):
kwargs['object_id'] = pk
changes = kwargs.get('changes', None)
# Delete log entries with the same pk as a newly created model. This should only happen when all records were
# deleted / the table was truncated.
if kwargs.get('action', None) is LogEntry.Action.CREATE:
if kwargs.get('object_id', None) is not None and self.exists(object_id=kwargs.get('object_id')):
self.filter(object_id=kwargs.get('object_id')).delete()
else:
self.filter(object_pk=kwargs.get('object_pk', '')).delete()
if changes is not None:
if not 'content_type' in kwargs:
kwargs['content_type'] = ContentType.objects.get_for_model(instance)
if not 'object_pk' in kwargs:
kwargs['object_pk'] = instance.pk
if not 'object_repr' in kwargs:
kwargs['object_repr'] = str(instance)
if not 'object_id' in kwargs:
pk_field = instance._meta.pk.name
pk = getattr(instance, pk_field, None)
if isinstance(pk, int):
kwargs['object_id'] = pk
return self.create(**kwargs)
# Delete log entries with the same pk as a newly created model. This should only happen when all records were
# deleted / the table was truncated.
if kwargs.get('action', None) is LogEntry.Action.CREATE:
if kwargs.get('object_id', None) is not None and self.exists(object_id=kwargs.get('object_id')):
self.filter(object_id=kwargs.get('object_id')).delete()
else:
self.filter(object_pk=kwargs.get('object_pk', '')).delete()
return self.create(**kwargs)
return None
class LogEntry(models.Model):

3
src/auditlog/receivers.py
View file

@ -17,7 +17,6 @@ def log_create(sender, instance, created, **kwargs):
action=LogEntry.Action.CREATE,
changes=json.dumps(changes),
)
log_entry.save()
def log_update(sender, instance, **kwargs):
@ -37,7 +36,6 @@ def log_update(sender, instance, **kwargs):
action=LogEntry.Action.UPDATE,
changes=json.dumps(changes),
)
log_entry.save()
def log_delete(sender, instance, **kwargs):
@ -54,4 +52,3 @@ def log_delete(sender, instance, **kwargs):
action=LogEntry.Action.DELETE,
changes=json.dumps(changes),
)
log_entry.save()