- using changes_dict to fix potential TypeError when changes are None in admin list view

This commit is contained in:
mrampant 2022-12-15 18:08:31 -05:00 committed by Hasan Ramezani
parent 703e3e4ba6
commit 8e496aadea

View file

@ -54,7 +54,7 @@ class LogEntryAdminMixin:
def msg_short(self, obj):
if obj.action in [LogEntry.Action.DELETE, LogEntry.Action.ACCESS]:
return "" # delete
changes = json.loads(obj.changes)
changes = obj.changes_dict
s = "" if len(changes) == 1 else "s"
fields = ", ".join(changes.keys())
if len(fields) > MAX:
@ -64,7 +64,7 @@ class LogEntryAdminMixin:
@admin.display(description=_("Changes"))
def msg(self, obj):
changes = json.loads(obj.changes)
changes = obj.changes_dict
atom_changes = {}
m2m_changes = {}