Hopiu/django-auditlog
1
0
Fork 0
mirror of https://github.com/jazzband/django-auditlog.git synced 2026-03-16 22:20:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

raise AuditLogRegistrationError on invalid app in settings (#492)

Browse source 
Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
This commit is contained in:
Thomas Steen Rasmussen 2023-01-03 16:03:37 +01:00 committed by GitHub
parent ffa6d34b11
commit b9a86df456
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
auditlog/registry.py
View file

@ -261,7 +261,13 @@ class AuditlogModelRegistry:
self.unregister(model_class)
self.register(model_class)
elif isinstance(model, dict):
model["model"] = self._get_model_classes(model["model"])[0]
appmodel = self._get_model_classes(model["model"])
if not appmodel:
raise AuditLogRegistrationError(
f"An error was encountered while registering model '{model['model']}' - "
"make sure the app is registered correctly."
)
model["model"] = appmodel[0]
self.unregister(model["model"])
self.register(**model)

12
auditlog_tests/tests.py
View file

@ -1158,6 +1158,18 @@ class RegisterModelSettingsTest(TestCase):
):
self.test_auditlog.register_from_settings()
with override_settings(
AUDITLOG_INCLUDE_TRACKING_MODELS=({"model": "notanapp.test"},)
):
with self.assertRaisesMessage(
AuditLogRegistrationError,
(
"An error was encountered while registering model 'notanapp.test'"
" - make sure the app is registered correctly."
),
):
self.test_auditlog.register_from_settings()
with override_settings(AUDITLOG_DISABLE_ON_RAW_SAVE="bad value"):
with self.assertRaisesMessage(
TypeError, "Setting 'AUDITLOG_DISABLE_ON_RAW_SAVE' must be a boolean"