Hopiu/django-auditlog
1
0
Fork 0
mirror of https://github.com/jazzband/django-auditlog.git synced 2026-04-30 03:34:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Eliminate sender from dispatch_uid

Browse source 
Django performs a lookup using (sender, dispatch_uid) as the key,
which means that including sender in dispatch_uid is redundant.
This commit is contained in:
Alieh Rymašeŭski 2021-06-28 15:17:59 +03:00
parent aa4f7a8108
commit bd68e2a619
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
auditlog/registry.py
View file

@ -4,7 +4,7 @@ from django.db.models import Model
from django.db.models.base import ModelBase
from django.db.models.signals import ModelSignal, post_delete, post_save, pre_save
DispatchUID = Tuple[int, str, int]
DispatchUID = Tuple[int, int, int]
class AuditlogModelRegistry(object):
@ -121,10 +121,11 @@ class AuditlogModelRegistry(object):
"""
Connect signals for the model.
"""
for signal in self._signals:
receiver = self._signals[signal]
for signal, receiver in self._signals.items():
signal.connect(
receiver, sender=model, dispatch_uid=self._dispatch_uid(signal, model)
receiver,
sender=model,
dispatch_uid=self._dispatch_uid(signal, receiver),
)
def _disconnect_signals(self, model):
@ -133,14 +134,12 @@ class AuditlogModelRegistry(object):
"""
for signal, receiver in self._signals.items():
signal.disconnect(
sender=model, dispatch_uid=self._dispatch_uid(signal, model)
sender=model, dispatch_uid=self._dispatch_uid(signal, receiver)
)
def _dispatch_uid(self, signal, model) -> DispatchUID:
"""
Generate a dispatch_uid.
"""
return self.__hash__(), model.__qualname__, signal.__hash__()
def _dispatch_uid(self, signal, receiver) -> DispatchUID:
"""Generate a dispatch_uid which is unique for a combination of self, signal, and receiver."""
return id(self), id(signal), id(receiver)
auditlog = AuditlogModelRegistry()