Commit graph

81 commits

Author SHA1 Message Date
Mozillazg
3cb36d9e24 Fixed typo 2014-02-21 13:22:58 +08:00
Jannis Leidel
49a52b7957 Merge pull request #11 from gthb/issue_15
Fix TypeError in edit_permissions
2014-02-20 17:53:22 +01:00
Jannis Leidel
f26feb3e47 Merge pull request #29 from gthb/fix-edit_permission-action
Fix edit permission action
2014-02-20 17:53:02 +01:00
Jannis Leidel
c394cc699e Merge pull request #28 from gthb/patch-1
Fix lurking bug in edit_permissions
2014-02-20 17:52:44 +01:00
mozillazg
00aaa026d9 Change argument extra_context's default value
Change keyword argument extra_context's default value from `{}` to `None`.
2014-02-20 22:11:57 +08:00
Gunnlaugur Þór Briem
37cef6308e Change submit name to make edit_permission work
Turns out that since Django 1.2 the admin only invokes actions when
handling POST if the POST data specifically *doesn't* contain `_save`:

cce32a9b09

So this submit name was preventing `edit_permission` from acting on the
POST data since Django 1.2.
2014-02-12 00:15:16 +00:00
Gunnlaugur Þór Briem
423bb90c71 Show action form errors using message_user
Not very neat, but way better than nothing when there are errors
(previously the error was invisible and the action simply seemed to have
completed).
2014-02-12 00:15:13 +00:00
Gunnlaugur Thor Briem
40924e532d Fix lurking bug in edit_permissions
I don't have a test case, this is just code review; that string extrapolation will always raise.
2014-02-11 11:20:31 +00:00
Wes Winham
13f425c5c2 Merge pull request #25 from gthb/fix-jsi18n-path
Fix hardcoded jsi18n script path
2014-02-10 13:25:31 -05:00
Gunnlaugur Þór Briem
0023127fc7 Fix hardcoded jsi18n script path
Use normal Django URL reversal instead of hardcoded relative path.
2014-02-10 18:05:18 +00:00
Gunnlaugur Þór Briem
c81f252840 Fix CSRF failure posting permission change form
Add missing `{% csrf_token %}` in form.

fixes #18
2014-02-10 18:03:24 +00:00
Wes Winham
426e0db6af Removed liar comment RE: smart cache default
The smart cache defaults to enabled.
2014-01-29 15:29:13 -05:00
Remigiusz Dymecki
d81caa6599 Fix import for Django 1.6 2013-12-06 01:43:37 +01:00
Jannis Leidel
ed096dcd21 Merge pull request #12 from gthb/django-deprecations
Fix django deprecations
2013-09-09 00:18:58 -07:00
Remigiusz Dymecki
27cfd0b0e5 backward compatible 2013-09-08 03:43:38 +02:00
Remigiusz Dymecki
dd04fecee6 Python3 update 2013-09-08 03:30:44 +02:00
Gunnlaugur Þór Briem
7dace16efd Fix remaining use of deprecated ADMIN_MEDIA_PREFIX 2013-07-30 18:57:38 +00:00
Gunnlaugur Þór Briem
fdab7e06fd Fix use of deprecated adminmedia taglib
and ADMIN_MEDIA_PREFIX setting
2013-07-13 01:30:38 +00:00
Gunnlaugur Þór Briem
32afb162ff Fix use of deprecated admin_site.root_path 2013-07-13 01:30:36 +00:00
Gunnlaugur Þór Briem
a88432cc28 Break out of for-loop when field found
Matching the `return` statement that the previous commit replaced.
2013-07-13 00:34:23 +00:00
Jason Ward
7ebbed7267 refs #9: no longer doing dependent sub-queries 2013-07-03 12:06:08 -04:00
Jason Ward
6752bb52c1 refs #9: had to bump the number of queries for a few things in order to stop doing dependent subqueries 2013-07-03 12:05:42 -04:00
Travis Chase
9c17430b03 Added custom user model and modified test run to use it when Django >= 1.5 2013-06-13 06:13:12 -05:00
Travis Chase
770e696313 Updated to be straight import for readability 2013-06-11 21:52:34 -05:00
Travis Chase
5a2ea092e6 Updates to handle custom user model change from Django 1.5 2013-06-11 17:26:41 -05:00
Gunnlaugur Þór Briem
6728ba94b3 Fix TypeError in edit_permissions under Django 1.3
Call superclass `formfield_for_dbfield` so that it gets to do its stuff
(including removing `request` from `kwargs`)

fixes: #15
2013-05-29 10:55:54 +00:00
Jason Ward
d53d9c3b3f refs #12: fixed updating checks tuple 2013-03-18 18:53:24 -04:00
Jason Ward
95610f9379 refs #11: All tests are now passing 2013-03-18 16:34:10 -04:00
Jason Ward
811e69b722 refs #11: Updated query counts to take into account the ContentType cache, fixed group caching tests 2013-03-18 16:26:50 -04:00
Jason Ward
1e9d33bc89 refs #11: basically got it working, two tests still failing 2013-03-18 16:08:51 -04:00
Jason Ward
a3a7093910 refs #11: name change since we are building a second perm cache 2013-03-18 15:58:10 -04:00
Jason Ward
4a9ed8aa9d refs #11: added tests for group caching 2013-03-18 15:46:34 -04:00
Jason Ward
6d6c91dfb6 refs #8: refactor 2012-09-26 17:23:30 -04:00
Jason Ward
342f3d5311 refs #8: name changes and used kwargs in one of the tests 2012-09-26 17:17:27 -04:00
Jason Ward
6326631756 refs #8: language cleanup, code cleanup 2012-09-26 16:27:33 -04:00
Jason Ward
8d62a86e96 refs #8: did a smarter job of building the cache without redoing work 2012-09-26 16:10:45 -04:00
Jason Ward
82bc7ee89e refs #8: updated the tests to the correct expected number of queries 2012-09-26 16:10:20 -04:00
Jason Ward
7c899a245d refs #7: doing the correct number of queries now 2012-09-26 16:01:01 -04:00
Jason Ward
2d71ba46b1 refs #7: wrote a test to show the expected number of queries needed for has_user_perms 2012-09-26 16:00:30 -04:00
Jason Ward
f6bba30407 refs #6: name change 2012-09-26 15:31:09 -04:00
Jason Ward
b81ef7b5d0 Merge remote-tracking branch 'origin/master' into issue_6
Conflicts:
	authority/permissions.py
2012-09-26 14:02:01 -04:00
Jason Ward
cb2d7c0280 refs #4: typo 2012-09-26 13:58:40 -04:00
Jason Ward
e8c7c46ab4 Merge remote-tracking branch 'origin/master' into issue_4
Conflicts:
	authority/permissions.py
2012-09-26 13:52:45 -04:00
Jason Ward
8b62ad97d2 refs #3: name changes to be more django 2012-09-26 13:47:16 -04:00
Jason Ward
513a1ad99a refs #3: small refactor 2012-09-26 13:41:48 -04:00
Jason Ward
1d8f743065 refs #3: typo 2012-09-26 13:38:14 -04:00
Jason Ward
263144831f refs #4: removed old comment 2012-09-26 11:09:15 -04:00
Jason Ward
de45b9535e refs #6: no longer relying on self.user being set 2012-09-25 16:43:05 -04:00
Jason Ward
6ff9c0f196 refs #6: updated the tests so that there was a permission that did not have a user 2012-09-25 16:08:09 -04:00
Jason Ward
289e9f0bdf refs #4: default to using the smart cache 2012-09-25 13:58:37 -04:00