From 46781441e2f0dfa2b0786a65e6873ae510e840eb Mon Sep 17 00:00:00 2001 From: Patrick Scott Best Date: Sun, 12 Jul 2020 22:08:07 -0400 Subject: [PATCH] Respect AVATAR_EXPOSE_USERNAMES for img alt This will prevent scraping "alts" for valid site usernames. Submitted for https://github.com/grantmcconnaughey/django-avatar/issues/188 --- avatar/templatetags/avatar_tags.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/avatar/templatetags/avatar_tags.py b/avatar/templatetags/avatar_tags.py index b8beb75..f4d10f0 100644 --- a/avatar/templatetags/avatar_tags.py +++ b/avatar/templatetags/avatar_tags.py @@ -42,13 +42,19 @@ def avatar(user, size=settings.AVATAR_DEFAULT_SIZE, **kwargs): if not isinstance(user, get_user_model()): try: user = get_user(user) - alt = six.text_type(user) + if settings.AVATAR_EXPOSE_USERNAMES: + alt = six.text_type(user) + else: + alt = _("User Avatar") url = avatar_url(user, size) except get_user_model().DoesNotExist: url = get_default_avatar_url() alt = _("Default Avatar") else: - alt = six.text_type(user) + if settings.AVATAR_EXPOSE_USERNAMES: + alt = six.text_type(user) + else: + alt = _("User Avatar") url = avatar_url(user, size) kwargs.update({'alt': alt})