From 8b4c522f5b3bd25ccc1d2bed1ce3c82c23bd3db1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aleksi=20Ha=CC=88kli?= Date: Sat, 16 Feb 2019 18:33:07 +0200 Subject: [PATCH] Rename Axes appconfig startup method to initialize MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Aleksi Häkli --- axes/apps.py | 4 ++-- axes/tests/test_logging.py | 16 ++++++++-------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/axes/apps.py b/axes/apps.py index 021d2a6..6366fcf 100644 --- a/axes/apps.py +++ b/axes/apps.py @@ -13,7 +13,7 @@ class AppConfig(apps.AppConfig): logging_initialized = False @classmethod - def log(cls): + def initialize(cls): """ Initialize Axes logging and show version information. @@ -39,7 +39,7 @@ class AppConfig(apps.AppConfig): log.info('AXES: blocking by IP only.') def ready(self): - self.log() + self.initialize() from axes import signals signals.ProxyHandler.initialize() diff --git a/axes/tests/test_logging.py b/axes/tests/test_logging.py index aa71111..d2b956e 100644 --- a/axes/tests/test_logging.py +++ b/axes/tests/test_logging.py @@ -10,34 +10,34 @@ from axes.apps import AppConfig class AppsTestCase(TestCase): def test_axes_config_log_re_entrant(self, log): """ - Test that log call count does not increase on repeat calls. + Test that initialize call count does not increase on repeat calls. """ - AppConfig.log() + AppConfig.initialize() calls = log.info.call_count - AppConfig.log() + AppConfig.initialize() self.assertTrue( calls == log.info.call_count and calls > 0, - 'AxesConfig.log needs to be re-entrant', + 'AxesConfig.initialize needs to be re-entrant', ) @override_settings(AXES_VERBOSE=False) def test_axes_config_log_not_verbose(self, log): - AppConfig.log() + AppConfig.initialize() self.assertFalse(log.info.called) @override_settings(AXES_ONLY_USER_FAILURES=True) def test_axes_config_log_user_only(self, log): - AppConfig.log() + AppConfig.initialize() log.info.assert_called_with('AXES: blocking by username only.') @override_settings(AXES_ONLY_USER_FAILURES=False) def test_axes_config_log_ip_only(self, log): - AppConfig.log() + AppConfig.initialize() log.info.assert_called_with('AXES: blocking by IP only.') @override_settings(AXES_LOCK_OUT_BY_COMBINATION_USER_AND_IP=True) def test_axes_config_log_user_ip(self, log): - AppConfig.log() + AppConfig.initialize() log.info.assert_called_with('AXES: blocking by combination of username and IP.')