Hopiu/django-axes
1
0
Fork 0
mirror of https://github.com/jazzband/django-axes.git synced 2026-03-16 22:30:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix AttributeError when optional settings are undefined

Browse source 
Fixes #1328
- Add None as default value in axes_conf_check
- Add test coverage for missing settings scenario
This commit is contained in:
rodrigo.nogueira 2025-12-29 10:58:44 -03:00 committed by Aleksi Häkli
parent f2af7c993b
commit 95a8043341
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
axes/checks.py
View file

@ -207,7 +207,7 @@ def axes_conf_check(app_configs, **kwargs): # pylint: disable=unused-argument
] ]
for callable_setting in callable_settings: for callable_setting in callable_settings:
value = getattr(settings, callable_setting) value = getattr(settings, callable_setting, None)
if not is_valid_callable(value): if not is_valid_callable(value):
warnings.append( warnings.append(
Warning( Warning(

5
tests/test_checks.py
View file

@ -129,3 +129,8 @@ class ConfCheckTestCase(AxesTestCase):
def test_valid_callable(self): def test_valid_callable(self):
warnings = run_checks() warnings = run_checks()
self.assertEqual(warnings, []) self.assertEqual(warnings, [])
def test_missing_settings_no_error(self):
warnings = run_checks()
self.assertEqual(warnings, [])