Hopiu/django-axes
1
0
Fork 0
mirror of https://github.com/jazzband/django-axes.git synced 2026-03-16 22:30:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Remove redundant AccessAttempt.failures property

Browse source 
Signed-off-by: Aleksi Häkli <aleksi.hakli@iki.fi>
This commit is contained in:
Aleksi Häkli 2019-02-16 18:31:16 +02:00 committed by Aleksi Häkli
parent c1ac9de894
commit b120fc6fde
No known key found for this signature in database
GPG key ID: 3E7146964D726BBE
3 changed files with 4 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
axes/management/commands/axes_list_attempts.py
View file

@ -8,8 +8,8 @@ class Command(BaseCommand):
def handle(self, *args, **options): # pylint: disable=unused-argument
for obj in AccessAttempt.objects.all():
self.stdout.write('{ip}\t{username}\t{failures}'.format(
self.stdout.write('{ip}\t{username}\t{failures_since_start}'.format(
ip=obj.ip_address,
username=obj.username,
failures=obj.failures,
failures_since_start=obj.failures_since_start,
))

8
axes/models.py
View file

@ -56,12 +56,8 @@ class AccessAttempt(AccessBase):
_('Failed Logins'),
)
@property
def failures(self):
return self.failures_since_start
def __str__(self):
return 'Attempted Access: %s' % self.attempt_time
return 'Attempted Access: {}'.format(self.attempt_time)
class Meta:
verbose_name = _('access attempt')
@ -83,7 +79,7 @@ class AccessLog(AccessBase):
)
def __str__(self):
return 'Access Log for %s @ %s' % (self.username, self.attempt_time)
return 'Access Log for {} @ {}'.format(self.username, self.attempt_time)
class Meta:
verbose_name = _('access log')

6
axes/tests/test_models.py
View file

@ -20,12 +20,6 @@ class ModelsTestCase(TestCase):
def test_access_attempt_str(self):
self.assertIn('Access', str(self.access_attempt))
def test_access_attempt_failures(self):
self.assertEqual(
self.access_attempt.failures,
self.failures_since_start,
)
def test_access_log_str(self):
self.assertIn('Access', str(self.access_log))