Hopiu/django-axes
1
0
Fork 0
mirror of https://github.com/jazzband/django-axes.git synced 2026-03-16 22:30:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Use term warning instead of error in check module code

Browse source
This commit is contained in:
Aleksi Häkli 2019-05-25 20:17:53 +03:00 committed by Aleksi Häkli
parent 41c4eda047
commit d0b21d3803
2 changed files with 32 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
axes/checks.py
View file

@ -44,42 +44,42 @@ def axes_cache_check(app_configs, **kwargs): # pylint: disable=unused-argument
'django.core.cache.backends.filebased.FileBasedCache',
]
errors = []
warnings = []
if axes_handler == 'axes.handlers.cache.AxesCacheHandler':
if axes_cache_backend in axes_cache_backend_incompatible:
errors.append(Warning(
warnings.append(Warning(
msg=Messages.CACHE_INVALID,
hint=Hints.CACHE_INVALID,
id=Codes.CACHE_INVALID,
))
return errors
return warnings
@register(Tags.security, Tags.compatibility)
def axes_middleware_check(app_configs, **kwargs): # pylint: disable=unused-argument
errors = []
warnings = []
if 'axes.middleware.AxesMiddleware' not in settings.MIDDLEWARE:
errors.append(Warning(
warnings.append(Warning(
msg=Messages.MIDDLEWARE_INVALID,
hint=Hints.MIDDLEWARE_INVALID,
id=Codes.MIDDLEWARE_INVALID,
))
return errors
return warnings
@register(Tags.security, Tags.compatibility)
def axes_backend_check(app_configs, **kwargs): # pylint: disable=unused-argument
errors = []
warnings = []
if 'axes.backends.AxesBackend' not in settings.AUTHENTICATION_BACKENDS:
errors.append(Warning(
warnings.append(Warning(
msg=Messages.BACKEND_INVALID,
hint=Hints.BACKEND_INVALID,
id=Codes.BACKEND_INVALID,
))
return errors
return warnings

40
axes/tests/test_checks.py
View file

@ -11,30 +11,32 @@ class CacheCheckTestCase(AxesTestCase):
CACHES={'default': {'BACKEND': 'django.core.cache.backends.db.DatabaseCache', 'LOCATION': 'axes_cache'}},
)
def test_cache_check(self):
errors = run_checks()
self.assertEqual([], errors)
warnings = run_checks()
self.assertEqual(warnings, [])
@override_settings(
AXES_HANDLER='axes.handlers.cache.AxesCacheHandler',
CACHES={'default': {'BACKEND': 'django.core.cache.backends.locmem.LocMemCache'}},
)
def test_cache_check_errors(self):
errors = run_checks()
error = Warning(
def test_cache_check_warnings(self):
warnings = run_checks()
warning = Warning(
msg=Messages.CACHE_INVALID,
hint=Hints.CACHE_INVALID,
id=Codes.CACHE_INVALID,
)
self.assertEqual([error], errors)
self.assertEqual(warnings, [
warning,
])
@override_settings(
AXES_HANDLER='axes.handlers.database.AxesDatabaseHandler',
CACHES={'default': {'BACKEND': 'django.core.cache.backends.locmem.LocMemCache'}},
)
def test_cache_check_does_not_produce_check_errors_with_database_handler(self):
errors = run_checks()
self.assertEqual([], errors)
def test_cache_check_does_not_produce_check_warnings_with_database_handler(self):
warnings = run_checks()
self.assertEqual(warnings, [])
class MiddlewareCheckTestCase(AxesTestCase):
@ -43,15 +45,17 @@ class MiddlewareCheckTestCase(AxesTestCase):
'remove': ['axes.middleware.AxesMiddleware']
},
)
def test_cache_check_errors(self):
errors = run_checks()
error = Warning(
def test_cache_check_warnings(self):
warnings = run_checks()
warning = Warning(
msg=Messages.MIDDLEWARE_INVALID,
hint=Hints.MIDDLEWARE_INVALID,
id=Codes.MIDDLEWARE_INVALID,
)
self.assertEqual([error], errors)
self.assertEqual(warnings, [
warning,
])
class BackendCheckTestCase(AxesTestCase):
@ -60,12 +64,14 @@ class BackendCheckTestCase(AxesTestCase):
'remove': ['axes.backends.AxesBackend']
},
)
def test_cache_check_errors(self):
errors = run_checks()
error = Warning(
def test_cache_check_warnings(self):
warnings = run_checks()
warning = Warning(
msg=Messages.BACKEND_INVALID,
hint=Hints.BACKEND_INVALID,
id=Codes.BACKEND_INVALID,
)
self.assertEqual([error], errors)
self.assertEqual(warnings, [
warning,
])